From: Julia Lawall <julia.lawall@inria.fr>
To: Jan Tojnar <jtojnar@gmail.com>
Cc: cocci@inria.fr
Subject: Re: [cocci] [PATCH v2] Exit with non-zero status when spatch on a directory fails
Date: Mon, 5 Sep 2022 18:03:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2209051757150.2731@hadrien> (raw)
In-Reply-To: <CAFGSp1vuGyiT86c7vq9MmYWaP06vRLo4OLQTREpHK_fw8vfEyg@mail.gmail.com>
The proposed behavior seems basically ok. It seems to have no impact if
one is not writing things to files.
But I wonder why not just check for !patching_failed before calling
generate_outfiles, and then putting the choice of exit status after the
whole "Main results analysis" block?
I don't think that the keep going flag is a good idea. It makes it sound
like that, without it, as soon as spatch fails on one file, it aborts
completely.
The correct patching_failed value is indeed not seen in the case of parmap
because modifications are not propagated back to the caller. One has to
add the value to the result.
julia
next prev parent reply other threads:[~2022-09-05 16:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 22:50 [cocci] [PATCH] Exit with non-zero status when spatch on a directory fails Jan Tojnar
2022-09-05 7:57 ` Julia Lawall
2022-09-05 9:09 ` [cocci] [PATCH v2] " Jan Tojnar
2022-09-05 10:48 ` Julia Lawall
2022-09-05 12:04 ` Jan Tojnar
2022-09-05 12:29 ` Julia Lawall
[not found] ` <CAFGSp1umoczUe4npSesAUOLgSq=9VkvLUOV3x1hSvSajqQkGfw@mail.gmail.com>
2022-09-05 12:51 ` Julia Lawall
2022-09-05 14:18 ` Jan Tojnar
2022-09-05 16:03 ` Julia Lawall [this message]
2022-09-05 19:51 ` Julia Lawall
2022-09-05 20:21 ` Jan Tojnar
2022-09-05 20:35 ` Julia Lawall
2022-10-22 12:09 ` Jan Tojnar
2022-10-22 12:26 ` Julia Lawall
2022-09-05 21:28 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2209051757150.2731@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=jtojnar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).