From: keescook@chromium.org (Kees Cook)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script
Date: Tue, 18 Jul 2017 09:21:07 -0700 [thread overview]
Message-ID: <CAGXu5jJgHumugb7F8GdDy911j7XvHNL9yW+tGsfkBHnR5-dTRA@mail.gmail.com> (raw)
In-Reply-To: <1500364111-2192-2-git-send-email-elena.reshetova@intel.com>
On Tue, Jul 18, 2017 at 12:48 AM, Elena Reshetova
<elena.reshetova@intel.com> wrote:
> atomic_as_refcounter.cocci script allows detecting
> cases when refcount_t type and API should be used
> instead of atomic_t.
>
> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
> ---
> scripts/coccinelle/api/atomic_as_refcounter.cocci | 102 ++++++++++++++++++++++
> 1 file changed, 102 insertions(+)
> create mode 100644 scripts/coccinelle/api/atomic_as_refcounter.cocci
>
> diff --git a/scripts/coccinelle/api/atomic_as_refcounter.cocci b/scripts/coccinelle/api/atomic_as_refcounter.cocci
> new file mode 100644
> index 0000000..a16d395
> --- /dev/null
> +++ b/scripts/coccinelle/api/atomic_as_refcounter.cocci
> @@ -0,0 +1,102 @@
> +// Check if refcount_t type and API should be used
> +// instead of atomic_t type when dealing with refcounters
> +//
> +// Copyright (c) 2016-2017, Elena Reshetova, Intel Corporation
> +//
> +// Confidence: Moderate
> +// URL: http://coccinelle.lip6.fr/
> +// Options: --include-headers --very-quiet
> +
> +virtual report
> +
> + at r1 exists@
> +identifier a, x, y;
> +position p1, p2;
> +identifier fname =~ ".*free.*";
> +identifier fname2 =~ ".*destroy.*";
> +identifier fname3 =~ ".*del.*";
> +identifier fname4 =~ ".*queue_work.*";
> +identifier fname5 =~ ".*schedule_work.*";
> +identifier fname6 =~ ".*call_rcu.*";
> +
> +@@
> +
> +(
> + atomic_dec_and_test at p1(&(a)->x)
> [...]
> +)
> +...
> +?y=a
> +...
> +(
> + fname at p2(a, ...);
> +|
> + fname at p2(y, ...);
> +|
> [...]
Just to double check, this "?y=a" catches the seccomp case I pointed out?
while (orig && atomic_dec_and_test(&orig->usage)) {
struct seccomp_filter *freeme = orig;
orig = orig->prev;
seccomp_filter_free(freeme);
}
Seems like it should match. Did this find anything else besides seccomp?
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-07-18 16:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 7:48 [Cocci] [PATCH] Coccinelle report script for refcounters Elena Reshetova
2017-07-18 7:48 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova
2017-07-18 16:21 ` Kees Cook [this message]
2017-07-19 10:54 ` Reshetova, Elena
2017-08-04 15:23 ` Julia Lawall
2017-08-07 11:06 ` Reshetova, Elena
2017-08-08 18:34 ` [Cocci] " SF Markus Elfring
2017-07-18 8:47 ` [Cocci] [PATCH] Coccinelle report script for refcounters Julia Lawall
2017-07-18 9:30 ` Reshetova, Elena
2017-07-18 11:53 ` Julia Lawall
2017-07-18 12:27 ` Reshetova, Elena
2017-07-18 15:10 ` Julia Lawall
2017-08-14 5:59 [Cocci] [PATCH v2] coccinelle: provide rule for finding refcounters Elena Reshetova
2017-08-14 5:59 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova
2017-08-14 14:16 ` Julia Lawall
2017-08-15 12:19 ` Reshetova, Elena
2017-08-16 11:52 [Cocci] [PATCH v3] provide rule for finding refcounters Elena Reshetova
2017-08-16 11:52 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova
2017-08-17 11:50 ` Julia Lawall
2017-08-29 9:01 ` Reshetova, Elena
2017-08-30 6:15 [Cocci] [PATCH v4] provide rule for finding refcounters Elena Reshetova
2017-08-30 6:15 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova
2017-08-30 12:26 ` Julia Lawall
2017-08-30 12:44 ` Reshetova, Elena
2017-08-30 13:06 ` Julia Lawall
2017-08-31 9:46 ` Reshetova, Elena
2017-09-01 9:40 Elena Reshetova
2018-06-14 23:58 ` Kees Cook
2018-06-15 5:06 ` Julia Lawall
2018-06-18 13:47 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jJgHumugb7F8GdDy911j7XvHNL9yW+tGsfkBHnR5-dTRA@mail.gmail.com \
--to=keescook@chromium.org \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).