From: julia.lawall@lip6.fr (Julia Lawall)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script
Date: Fri, 4 Aug 2017 17:23:03 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1708041720440.22068@hadrien> (raw)
In-Reply-To: <1500364111-2192-2-git-send-email-elena.reshetova@intel.com>
On Tue, 18 Jul 2017, Elena Reshetova wrote:
> atomic_as_refcounter.cocci script allows detecting
> cases when refcount_t type and API should be used
> instead of atomic_t.
>
> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
> ---
> scripts/coccinelle/api/atomic_as_refcounter.cocci | 102 ++++++++++++++++++++++
> 1 file changed, 102 insertions(+)
> create mode 100644 scripts/coccinelle/api/atomic_as_refcounter.cocci
>
> diff --git a/scripts/coccinelle/api/atomic_as_refcounter.cocci b/scripts/coccinelle/api/atomic_as_refcounter.cocci
> new file mode 100644
> index 0000000..a16d395
> --- /dev/null
> +++ b/scripts/coccinelle/api/atomic_as_refcounter.cocci
> @@ -0,0 +1,102 @@
> +// Check if refcount_t type and API should be used
> +// instead of atomic_t type when dealing with refcounters
> +//
> +// Copyright (c) 2016-2017, Elena Reshetova, Intel Corporation
> +//
> +// Confidence: Moderate
> +// URL: http://coccinelle.lip6.fr/
> +// Options: --include-headers --very-quiet
> +
> +virtual report
> +
> + at r1 exists@
> +identifier a, x, y;
> +position p1, p2;
> +identifier fname =~ ".*free.*";
> +identifier fname2 =~ ".*destroy.*";
> +identifier fname3 =~ ".*del.*";
> +identifier fname4 =~ ".*queue_work.*";
> +identifier fname5 =~ ".*schedule_work.*";
> +identifier fname6 =~ ".*call_rcu.*";
> +
> +@@
> +
> +(
> + atomic_dec_and_test at p1(&(a)->x)
> +|
> + atomic_dec_and_lock at p1(&(a)->x, ...)
> +|
> + atomic_long_dec_and_lock at p1(&(a)->x, ...)
> +|
> + atomic_long_dec_and_test at p1(&(a)->x)
> +|
> + atomic64_dec_and_test at p1(&(a)->x)
> +|
> + local_dec_and_test at p1(&(a)->x)
> +)
> +...
> +?y=a
This makes the line optional. And if it dosn't appear, there is no
constraint on y. So the rule matches:
int main() {
atomic64_dec_and_test(&(a)->x);
free(b);
}
I would suggest to just make two rules, one with y=a and one without.
julia
> +...
> +(
> + fname at p2(a, ...);
> +|
> + fname at p2(y, ...);
> +|
> + fname2 at p2(...);
> +|
> + fname3 at p2(...);
> +|
> + fname4 at p2(...);
> +|
> + fname5 at p2(...);
> +|
> + fname6 at p2(...);
> +)
> +
> +
> + at script:python depends on report@
> +p1 << r1.p1;
> +p2 << r1.p2;
> +@@
> +msg = "atomic_dec_and_test variation before object free at line %s."
> +coccilib.report.print_report(p1[0], msg % (p2[0].line))
> +
> + at r2 exists@
> +identifier a, x;
> +position p1;
> +@@
> +
> +(
> +atomic_add_unless(&(a)->x,-1,1)@p1
> +|
> +atomic_long_add_unless(&(a)->x,-1,1)@p1
> +|
> +atomic64_add_unless(&(a)->x,-1,1)@p1
> +)
> +
> + at script:python depends on report@
> +p1 << r2.p1;
> +@@
> +msg = "atomic_add_unless"
> +coccilib.report.print_report(p1[0], msg)
> +
> + at r3 exists@
> +identifier x;
> +position p1;
> +@@
> +
> +(
> +x = atomic_add_return at p1(-1, ...);
> +|
> +x = atomic_long_add_return at p1(-1, ...);
> +|
> +x = atomic64_add_return at p1(-1, ...);
> +)
> +
> + at script:python depends on report@
> +p1 << r3.p1;
> +@@
> +msg = "x = atomic_add_return(-1, ...)"
> +coccilib.report.print_report(p1[0], msg)
> +
> +
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2017-08-04 15:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 7:48 [Cocci] [PATCH] Coccinelle report script for refcounters Elena Reshetova
2017-07-18 7:48 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova
2017-07-18 16:21 ` Kees Cook
2017-07-19 10:54 ` Reshetova, Elena
2017-08-04 15:23 ` Julia Lawall [this message]
2017-08-07 11:06 ` Reshetova, Elena
2017-08-08 18:34 ` [Cocci] " SF Markus Elfring
2017-07-18 8:47 ` [Cocci] [PATCH] Coccinelle report script for refcounters Julia Lawall
2017-07-18 9:30 ` Reshetova, Elena
2017-07-18 11:53 ` Julia Lawall
2017-07-18 12:27 ` Reshetova, Elena
2017-07-18 15:10 ` Julia Lawall
2017-08-14 5:59 [Cocci] [PATCH v2] coccinelle: provide rule for finding refcounters Elena Reshetova
2017-08-14 5:59 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova
2017-08-14 14:16 ` Julia Lawall
2017-08-15 12:19 ` Reshetova, Elena
2017-08-16 11:52 [Cocci] [PATCH v3] provide rule for finding refcounters Elena Reshetova
2017-08-16 11:52 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova
2017-08-17 11:50 ` Julia Lawall
2017-08-29 9:01 ` Reshetova, Elena
2017-08-30 6:15 [Cocci] [PATCH v4] provide rule for finding refcounters Elena Reshetova
2017-08-30 6:15 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova
2017-08-30 12:26 ` Julia Lawall
2017-08-30 12:44 ` Reshetova, Elena
2017-08-30 13:06 ` Julia Lawall
2017-08-31 9:46 ` Reshetova, Elena
2017-09-01 9:40 Elena Reshetova
2018-06-14 23:58 ` Kees Cook
2018-06-15 5:06 ` Julia Lawall
2018-06-18 13:47 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1708041720440.22068@hadrien \
--to=julia.lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).