* Re: [Cocci] [V3] amdgpu: remove unnecessary condition check
[not found] ` <ccd14dee-f275-5de4-b5c1-4f359d155288@amd.com>
@ 2020-04-21 10:00 ` Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-04-21 10:00 UTC (permalink / raw)
To: Christian König, 赵军奎, amd-gfx, dri-devel
Cc: Chunming Zhou, opensource.kernel, David Airlie,
Felix Kühling, kernel-janitors, LKML, Daniel Vetter,
Alex Deucher, Coccinelle
>> But i have to say there are so many code not follow the kernel code-style in amdgpu module.
>> And also the ./scripts/checkpatch.pl did not throw any warning or error.
>
> That is unfortunately true, yes. But we try to push new code through the usual code review and improve things as we go.
>
> On the other hand patches just to fix the coding style are usually seen as an unnecessary interruption and just a waste of time.
Would you become interested in adjusting deviations from known programming guidelines
in an automatic way with the help of corresponding advanced development tools?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-21 10:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <AIsA-wCZCFCxiq0WKb3WjKr*.3.1587458683834.Hmail.bernard@vivo.com>
[not found] ` <ccd14dee-f275-5de4-b5c1-4f359d155288@amd.com>
2020-04-21 10:00 ` [Cocci] [V3] amdgpu: remove unnecessary condition check Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).