From: Markus Elfring <Markus.Elfring@web.de>
To: Coccinelle <cocci@systeme.lip6.fr>
Subject: [Cocci] Checking data processing for clk_put.cocci
Date: Wed, 6 Nov 2019 18:48:13 +0100 [thread overview]
Message-ID: <aefeb780-642e-b5d4-5afe-f767683e4c2d@web.de> (raw)
Hello,
I would like to clarify the following source code analysis result
which can be provided by the tool “coccicheck”.
./drivers/bus/ti-sysc.c:1776:2-8: ERROR: missing clk_put; clk_get on line 1767 and execution via conditional on line 1775
./drivers/tty/serial/bcm63xx_uart.c:851:2-8: ERROR: missing clk_put; clk_get on line 846 and execution via conditional on line 850
I have got the impression that false positives are reported for
the implementations of the functions “sysc_child_add_named_clock”
and “bcm_uart_probe” so far because variable assignment exclusions
were not specified as when constraints for the involved script
for the semantic patch language.
https://elixir.bootlin.com/linux/v5.4-rc5/source/drivers/bus/ti-sysc.c#L1784
https://elixir.bootlin.com/linux/v5.4-rc5/source/drivers/tty/serial/bcm63xx_uart.c#L811
How do you think about it?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccinelle/free/clk_put.cocci?id=26bc672134241a080a83b2ab9aa8abede8d30e1c#n2
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
reply other threads:[~2019-11-06 17:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aefeb780-642e-b5d4-5afe-f767683e4c2d@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).