[Cocci] Removing trailing whitespace at the end of changes lines?

[Cocci] Removing trailing whitespace at the end of changes lines?

[Timur Tabi]

I've noticed that some lines changed with my cocci script have a
trailing whitespace at the end of the first line.  For example:

-        DBG_PRINTF((DBG_MODULE_GLOBAL, DBG_LEVEL_ERRORS,
-                    "NVRM: %s: failed to save GPU crash data\n",
-                    __FUNCTION__));
+        NV_PRINTF(LEVEL_ERROR,
+                  "%s: failed to save GPU crash data\n", __FUNCTION__);

There is a blank space after "LEVEL_ERROR,".  I've attached my cocci
script, but considering that coccinelle seems to reformat lines after
they've been modified,
I suspect that the problem is not in my script per se.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nv_printf.cocci
Type: application/octet-stream
Size: 1915 bytes
Desc: not available
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20180730/592b7c82/attachment.obj>

[Cocci] Removing trailing whitespace at the end of changes lines?

[Julia Lawall]

On Mon, 30 Jul 2018, Timur Tabi wrote:

> I've noticed that some lines changed with my cocci script have a
> trailing whitespace at the end of the first line.  For example:
>
> -        DBG_PRINTF((DBG_MODULE_GLOBAL, DBG_LEVEL_ERRORS,
> -                    "NVRM: %s: failed to save GPU crash data\n",
> -                    __FUNCTION__));
> +        NV_PRINTF(LEVEL_ERROR,
> +                  "%s: failed to save GPU crash data\n", __FUNCTION__);
>
> There is a blank space after "LEVEL_ERROR,".  I've attached my cocci
> script, but considering that coccinelle seems to reformat lines after
> they've been modified,
> I suspect that the problem is not in my script per se.

Coccinelle makes some special efforts to add newlines to respect the 80
character boundary.  It seems that the associated space is not always
getting removed.  I will try to take a look.

julia

[Cocci] Removing trailing whitespace at the end of changes lines?

[Timur Tabi]

On Mon, Jul 30, 2018 at 3:21 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> Coccinelle makes some special efforts to add newlines to respect the 80
> character boundary.  It seems that the associated space is not always
> getting removed.  I will try to take a look.

It appears to happen only when the second parameter is on the second
line.  That is, the LEVEL_xxx parameter is the only parameter on the
first line.

[Cocci] Removing trailing whitespace at the end of changes lines?

[Julia Lawall]

On Mon, 30 Jul 2018, Timur Tabi wrote:

> I've noticed that some lines changed with my cocci script have a
> trailing whitespace at the end of the first line.  For example:
>
> -        DBG_PRINTF((DBG_MODULE_GLOBAL, DBG_LEVEL_ERRORS,
> -                    "NVRM: %s: failed to save GPU crash data\n",
> -                    __FUNCTION__));
> +        NV_PRINTF(LEVEL_ERROR,
> +                  "%s: failed to save GPU crash data\n", __FUNCTION__);
>
> There is a blank space after "LEVEL_ERROR,".  I've attached my cocci
> script, but considering that coccinelle seems to reformat lines after
> they've been modified,
> I suspect that the problem is not in my script per se.

Could you send a .c file that produces the problem?  I tried with the
attached file but I don't get any trailing spaces.

julia

-------------- next part --------------
A non-text attachment was scrubbed...
Name: nv_printf.c
Type: text/x-csrc
Size: 171 bytes
Desc: 
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20180731/e82135ec/attachment.bin>