cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
* [Cocci] Whitespace Issue When Adding "!!"
@ 2019-02-01 13:53 Michael Stefaniuc
  2019-02-01 20:42 ` Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Stefaniuc @ 2019-02-01 13:53 UTC (permalink / raw)
  To: Cocci

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

Hello,

when adding a "!!" the generated diff will have "! !".
Test case and results are attached.

thanks
bye
       michael

[-- Attachment #2: notnot.c --]
[-- Type: text/plain, Size: 53 bytes --]

bool foo(int bar)
{
    return bar ? true : false;
}

[-- Attachment #3: notnot.cocci --]
[-- Type: text/plain, Size: 48 bytes --]

@@
expression E;
@@
+ !!
  E
-   ? true : false

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: notnot.res --]
[-- Type: text/x-diff; name=notnot.res, Size: 155 bytes --]

--- /tmp/notnot.c
+++ /tmp/cocci-output-18828-5323c2-notnot.c
@@ -1,4 +1,4 @@
 bool foo(int bar)
 {
-    return bar ? true : false;
+    return ! !bar;
 }

[-- Attachment #5: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Cocci] Whitespace Issue When Adding "!!"
  2019-02-01 13:53 [Cocci] Whitespace Issue When Adding "!!" Michael Stefaniuc
@ 2019-02-01 20:42 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2019-02-01 20:42 UTC (permalink / raw)
  To: Michael Stefaniuc; +Cc: Cocci



On Fri, 1 Feb 2019, Michael Stefaniuc wrote:

> Hello,
>
> when adding a "!!" the generated diff will have "! !".
> Test case and results are attached.

This should be fixed now.  Thanks for the report.

julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-01 20:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-01 13:53 [Cocci] Whitespace Issue When Adding "!!" Michael Stefaniuc
2019-02-01 20:42 ` Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).