* [cocci] [PATCH] scripts: coccicheck: Avoid warning about spurious escape
@ 2023-01-13 17:29 Peter Foley
2023-01-26 15:38 ` Markus Elfring
2023-02-25 19:27 ` Julia Lawall
0 siblings, 2 replies; 3+ messages in thread
From: Peter Foley @ 2023-01-13 17:29 UTC (permalink / raw)
To: Julia Lawall, Nicolas Palix; +Cc: cocci, linux-kernel, Peter Foley
e.g.
grep: warning: stray \ before -
Signed-off-by: Peter Foley <pefoley2@pefoley.com>
---
scripts/coccicheck | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index 2956fce8fa4f..fb492f032c5f 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -18,7 +18,7 @@ fi
SPATCH_VERSION=$($SPATCH --version | head -1 | awk '{print $3}')
USE_JOBS="no"
-$SPATCH --help | grep "\-\-jobs" > /dev/null && USE_JOBS="yes"
+$SPATCH --help | grep -e "--jobs" > /dev/null && USE_JOBS="yes"
# The verbosity may be set by the environmental parameter V=
# as for example with 'make V=1 coccicheck'
---
base-commit: d9fc1511728c15df49ff18e49a494d00f78b7cd4
change-id: 20230113-cocci-12936b2c06c3
Best regards,
--
Peter Foley <pefoley2@pefoley.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [cocci] [PATCH] scripts: coccicheck: Avoid warning about spurious escape
2023-01-13 17:29 [cocci] [PATCH] scripts: coccicheck: Avoid warning about spurious escape Peter Foley
@ 2023-01-26 15:38 ` Markus Elfring
2023-02-25 19:27 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2023-01-26 15:38 UTC (permalink / raw)
To: Peter Foley, cocci, Julia Lawall; +Cc: LKML, kernel-janitors, Nicolas Palix
> +++ b/scripts/coccicheck
…
> +$SPATCH --help | grep -e "--jobs" > /dev/null && USE_JOBS="yes"
How do you think about to use single quotes instead of double quotes?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [cocci] [PATCH] scripts: coccicheck: Avoid warning about spurious escape
2023-01-13 17:29 [cocci] [PATCH] scripts: coccicheck: Avoid warning about spurious escape Peter Foley
2023-01-26 15:38 ` Markus Elfring
@ 2023-02-25 19:27 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2023-02-25 19:27 UTC (permalink / raw)
To: Peter Foley; +Cc: Nicolas Palix, cocci, linux-kernel
On Fri, 13 Jan 2023, Peter Foley wrote:
> e.g.
> grep: warning: stray \ before -
>
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
Applied, thanks.
julia
> ---
> scripts/coccicheck | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 2956fce8fa4f..fb492f032c5f 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -18,7 +18,7 @@ fi
> SPATCH_VERSION=$($SPATCH --version | head -1 | awk '{print $3}')
>
> USE_JOBS="no"
> -$SPATCH --help | grep "\-\-jobs" > /dev/null && USE_JOBS="yes"
> +$SPATCH --help | grep -e "--jobs" > /dev/null && USE_JOBS="yes"
>
> # The verbosity may be set by the environmental parameter V=
> # as for example with 'make V=1 coccicheck'
>
> ---
> base-commit: d9fc1511728c15df49ff18e49a494d00f78b7cd4
> change-id: 20230113-cocci-12936b2c06c3
>
> Best regards,
> --
> Peter Foley <pefoley2@pefoley.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-25 19:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 17:29 [cocci] [PATCH] scripts: coccicheck: Avoid warning about spurious escape Peter Foley
2023-01-26 15:38 ` Markus Elfring
2023-02-25 19:27 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).