cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Jaskaran Singh <jaskaran.singh@collabora.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	Julia Lawall <julia.lawall@inria.fr>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] [00/43] cocci: Add support for meta attributes to SmPL
Date: Mon, 03 Aug 2020 13:52:09 +0530	[thread overview]
Message-ID: <ba1f8a2dc9e079bc01fc2037f1246f25cd956ee5.camel@collabora.com> (raw)
In-Reply-To: <3474ebf5-c902-63e9-8244-08a0f3407b72@web.de>

On Mon, 2020-08-03 at 07:37 +0200, Markus Elfring wrote:
> > > Do you care if a SmPL name variable would accidentally not be
> > > used
> > > (like in the script “
> > > https://github.com/coccinelle/coccinelle/blob/04f36d537b9f6c0c127d05184cccd21f1a46b952/tests/metaattr.cocci#L2”
> > > )?
> > 
> > It actually is used, to help parsing the .c file.  This information
> > will
> > be added to the documentation shortly.
> 
> I would expect that the following SmPL script variant will generate
> also a patch.
> (Why would extra “help” be needed for parsing source files?)
> 
> @replacement@
> attribute a;
> identifier b;
> @@
> -int
> +char
>  b a = 1;
> 
> 
> By the way:
> I have noticed another detail which I find questionable at the
> moment.
> 
> elfring@Sonne:~/Projekte/Coccinelle/20160205> spatch --parse-cocci
> tests/metaattr-2.cocci
> …
> (
> -int
>   >>> char
>  b a = 1;
> -signed
>   >>> char
> -int b a = 1;
> )
> …
> 

Probably a pretty printing mistake. I'll fix this.

Thanks,
Jaskaran.

> I would interpret the display for the second part of such a SmPL
> disjunction
> in the way that a variable definition will be deleted (instead of
> taking only
> the key word “signed” also into account according to the isomorphism
> “add_signed”).
> 
> Regards,
> Markus

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply	other threads:[~2020-08-03  8:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e4f3c4e8-03e8-dbc2-5871-0d111b3086a4@web.de>
2020-08-02  7:06 ` [Cocci] [PATCH 00/43] cocci: Add support for meta attributes to SmPL Julia Lawall
     [not found]   ` <eead5e2a-da8d-83cd-eeb4-f193702b800f@web.de>
2020-08-02 11:48     ` Julia Lawall
     [not found]       ` <82af6b44-ea09-b86f-81f7-e96e8594a31d@web.de>
2020-08-02 13:13         ` [Cocci] [00/43] " Julia Lawall
     [not found]           ` <065fee88-5206-5d9b-c83c-4e6a20aefd85@web.de>
2020-08-02 14:34             ` Julia Lawall
     [not found]               ` <8f357aa0-7811-a5b8-a061-814899654e88@web.de>
2020-08-02 15:34                 ` Julia Lawall
     [not found]                   ` <c1822815-456f-316d-93b5-88beb55a0d69@web.de>
2020-08-02 16:16                     ` Julia Lawall
     [not found]                       ` <74a5a472-4431-46e7-bd8b-95886f031c93@web.de>
2020-08-02 17:00                         ` Julia Lawall
     [not found]                           ` <3474ebf5-c902-63e9-8244-08a0f3407b72@web.de>
2020-08-03  5:46                             ` Julia Lawall
2020-08-03  8:22                             ` Jaskaran Singh [this message]
     [not found]                               ` <04cb5eb3-bed8-9e8e-255b-fbae06144016@web.de>
2020-08-08 11:35                                 ` Jaskaran Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba1f8a2dc9e079bc01fc2037f1246f25cd956ee5.camel@collabora.com \
    --to=jaskaran.singh@collabora.com \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).