* [cocci] [PATCH] pmdomain: ti: Use common error handling code in ti_sci_pm_domain_probe()
@ 2023-11-05 14:52 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2023-11-05 14:52 UTC (permalink / raw)
To: Julia Lawall, Nishanth Menon, Santosh Shilimkar, Tero Kristo,
Ulf Hansson, linux-arm-kernel, linux-pm, kernel-janitors
Cc: cocci, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Nov 2023 15:30:28 +0100
Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pmdomain/ti/ti_sci_pm_domains.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c
index c091d569ecd5..af8a1ed2db70 100644
--- a/drivers/pmdomain/ti/ti_sci_pm_domains.c
+++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c
@@ -153,18 +153,14 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev)
max_id = args.args[0];
pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL);
- if (!pd) {
- of_node_put(np);
- return -ENOMEM;
- }
+ if (!pd)
+ goto put_node;
pd->pd.name = devm_kasprintf(dev, GFP_KERNEL,
"pd:%d",
args.args[0]);
- if (!pd->pd.name) {
- of_node_put(np);
- return -ENOMEM;
- }
+ if (!pd->pd.name)
+ goto put_node;
pd->pd.power_off = ti_sci_pd_power_off;
pd->pd.power_on = ti_sci_pd_power_on;
@@ -193,6 +189,10 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev)
pd_provider->data.domains[pd->idx] = &pd->pd;
return of_genpd_add_provider_onecell(dev->of_node, &pd_provider->data);
+
+put_node:
+ of_node_put(np);
+ return -ENOMEM;
}
static struct platform_driver ti_sci_pm_domains_driver = {
--
2.42.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-11-05 14:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-05 14:52 [cocci] [PATCH] pmdomain: ti: Use common error handling code in ti_sci_pm_domain_probe() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).