Re: dnsproxy: first round of refactoring, TCP bugfix

[Daniel Wagner <wagi@monom.org>]

Hi Matthias,

On Tue, Apr 19, 2022 at 12:34:49PM +0200, Matthias Gerstner wrote:
> This is a first iteration of refactoring the dnsproxy codebase. It is no major
> change of the code structure yet, more a local refactoring of each function
> trying to make the existing code more readable and less redundant.
> 
> Part of this is also improved testing capability, minor fixes of bugs
> encountered during refactoring and a bugfix of the TCP protocol operation if
> domain name appending is in effect.

Nice work. A few nits from my side. The cleanup generally looks good.

Though we need set the C standard to C99 I suppose:


src/dnsproxy.c: In function ‘refresh_dns_entry’:
src/dnsproxy.c:394:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  394 |         int age = 1;
      |         ^~~

and my compiler complained about a few things:

src/dnsproxy.c:410:25: error: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
  410 |         if (entry->hits > age)
      |                         ^
src/dnsproxy.c: In function ‘update_cached_ttl’:
src/dnsproxy.c:432:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]
  432 |         if (len < sizeof(struct domain_question) + 1)
      |                 ^
[...]

BTW, since this contribution is major I would suggest you add your
copyright statement to the file as well.

Thanks,
Daniel