From: Matthias Gerstner <matthias.gerstner@suse.de>
To: Daniel Wagner <wagi@monom.org>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 03/12] dnsproxy: refactoring of update_cached_ttl() and append_data()
Date: Fri, 10 Jun 2022 14:26:09 +0200 [thread overview]
Message-ID: <YqM4YXG2KSWlIKj2@kasco.suse.de> (raw)
In-Reply-To: <20220525064509.6oohjixx3laz2plg@beryllium.lan>
[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]
Hi Daniel,
On Wed, May 25, 2022 at 08:45:09AM +0200, Daniel Wagner wrote:
> On Tue, Apr 19, 2022 at 12:34:52PM +0200, Matthias Gerstner wrote:
> > + ptr += DNS_HEADER_SIZE;
> > + len -= DNS_HEADER_SIZE;
>
> here the 'sizeof(struct ...)' is hidden in the define
>
> > +
> > + if (len < sizeof(struct domain_question) + 1)
> > + return;
> >
> > - /* skip the query, which is a name and 2 16 bit words */
> > - l = dns_name_length(c);
> > - c += l;
> > - len -= l;
> > - c += 4;
> > - len -= 4;
> > + /* skip the query, which is a name and a struct domain_question */
> > + size_t name_len = dns_name_length(ptr);
> > +
> > + ptr += name_len + sizeof(struct domain_question);
>
> and here we have the sizeof(struct ...). Personally I prefer the later
> over the former because I don't have to lookup what the define is
> doing. But then I do understand that it a good name of a define helps to
> read. So just pick one version of it.
I mostly wanted the define because of the frequently occuring and
complex `sizeof(domain_hdr)` calculations. For the sake of unity I will
add a few additional defines for the other sizeof() occurences.
Cheers
Matthias
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-06-10 12:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 10:34 dnsproxy: first round of refactoring, TCP bugfix Matthias Gerstner
2022-04-19 10:34 ` [PATCH 01/12] dnsproxy-simple-test: improve test coverage and test flexibility Matthias Gerstner
2022-04-19 10:34 ` [PATCH 02/12] dnsproxy: first bits of refactoring data types, global variables, simpler functions Matthias Gerstner
2022-05-25 6:47 ` Daniel Wagner
2022-05-25 6:48 ` Daniel Wagner
2022-04-19 10:34 ` [PATCH 03/12] dnsproxy: refactoring of update_cached_ttl() and append_data() Matthias Gerstner
2022-05-25 6:45 ` Daniel Wagner
2022-06-10 12:26 ` Matthias Gerstner [this message]
2022-04-19 10:34 ` [PATCH 04/12] dnsproxy: refactor parse_response() Matthias Gerstner
2022-04-19 10:34 ` [PATCH 05/12] dnsproxy: further refactoring of cache_update() Matthias Gerstner
2022-05-25 6:51 ` Daniel Wagner
2022-04-19 10:34 ` [PATCH 06/12] dnsproxy: strip_domains(): fix out of bounds read access Matthias Gerstner
2022-04-19 10:34 ` [PATCH 07/12] dnsproxy: refactor and document strip_domains() to make it less confusing Matthias Gerstner
2022-04-19 10:34 ` [PATCH 08/12] dnsproxy: refactor larger functions ns_resolv() and forwards_dns_reply() Matthias Gerstner
2022-04-19 10:34 ` [PATCH 09/12] dnsproxy: uncompress: replace unnecessary goto with return statements Matthias Gerstner
2022-04-19 10:34 ` [PATCH 10/12] dnsproxy: forward_dns_reply: pull out separate dns_reply_fixup_domains() Matthias Gerstner
2022-04-19 10:35 ` [PATCH 11/12] dnsproxy: finish first pass of refactoring the compilation unit Matthias Gerstner
2022-04-19 10:35 ` [PATCH 12/12] dnsproxy: fix TCP server reply handling if domain name is appended Matthias Gerstner
2022-05-25 7:01 ` dnsproxy: first round of refactoring, TCP bugfix Daniel Wagner
2022-06-10 12:28 ` Matthias Gerstner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqM4YXG2KSWlIKj2@kasco.suse.de \
--to=matthias.gerstner@suse.de \
--cc=connman@lists.linux.dev \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).