* [PATCH v1 0/2] Fix a couple of regression
@ 2022-12-18 19:28 Daniel Wagner
2022-12-18 19:28 ` [PATCH v1 1/2] ipconfig: Do not filter out 0.0.0.0 gateway routes Daniel Wagner
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Daniel Wagner @ 2022-12-18 19:28 UTC (permalink / raw)
To: connman; +Cc: Geoffrey Van Landeghem, i . Dark_Templar, Daniel Wagner
A bunch of fixes for the recentently reported regressions:
- https://lore.kernel.org/connman/66993511-8b3c-bf48-beaf-9ff9e6ee446b@gmail.com/T/#u
- https://lore.kernel.org/connman/b4938292-e2a0-e572-77c1-19dda0a16d0c@dark-templar-archives.net/
Daniel Wagner (2):
ipconfig: Do not filter out 0.0.0.0 gateway routes
main: Add Hamachi interface to ignore list
src/ipconfig.c | 2 +-
src/main.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.39.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/2] ipconfig: Do not filter out 0.0.0.0 gateway routes
2022-12-18 19:28 [PATCH v1 0/2] Fix a couple of regression Daniel Wagner
@ 2022-12-18 19:28 ` Daniel Wagner
2022-12-18 19:28 ` [PATCH v1 2/2] main: Add Hamachi interface to ignore list Daniel Wagner
2023-01-02 8:16 ` [PATCH v1 0/2] Fix a couple of regression Daniel Wagner
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Wagner @ 2022-12-18 19:28 UTC (permalink / raw)
To: connman; +Cc: Geoffrey Van Landeghem, i . Dark_Templar, Daniel Wagner
This reverts commit cb05780d86c3 ("ipconfig: Don't add invalid gateway
routes") as it introduced regressions for IPv4LL setups.
0.0.0.0 is a valid gateway address for IPv4LL setups (see forwarding
rules in RFC3927).
Reported by Geoffrey Van Landeghem <geoffrey.vl@gmail.com>
---
src/ipconfig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 9f17f4989ea8..34b1724a22bb 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -1172,7 +1172,7 @@ int __connman_ipconfig_gateway_add(struct connman_ipconfig *ipconfig)
DBG("");
- if (!ipconfig->address || !ipconfig->address->gateway)
+ if (!ipconfig->address)
return -EINVAL;
service = __connman_service_lookup_from_index(ipconfig->index);
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1 2/2] main: Add Hamachi interface to ignore list
2022-12-18 19:28 [PATCH v1 0/2] Fix a couple of regression Daniel Wagner
2022-12-18 19:28 ` [PATCH v1 1/2] ipconfig: Do not filter out 0.0.0.0 gateway routes Daniel Wagner
@ 2022-12-18 19:28 ` Daniel Wagner
2023-01-02 8:16 ` [PATCH v1 0/2] Fix a couple of regression Daniel Wagner
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Wagner @ 2022-12-18 19:28 UTC (permalink / raw)
To: connman; +Cc: Geoffrey Van Landeghem, i . Dark_Templar, Daniel Wagner
The Hamachi VPN daemon setups a network interface calles 'ham0' which
is under control of this daemon. ConnMan should ignore it and not
starting to auto configure it.
Reported by: i.Dark_Templar <darktemplar@dark-templar-archives.net>
---
src/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/main.c b/src/main.c
index 70277f66efce..ae4a450dea11 100644
--- a/src/main.c
+++ b/src/main.c
@@ -78,6 +78,7 @@ static char *default_blacklist[] = {
"ifb",
"ve-",
"vb-",
+ "ham",
NULL
};
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 0/2] Fix a couple of regression
2022-12-18 19:28 [PATCH v1 0/2] Fix a couple of regression Daniel Wagner
2022-12-18 19:28 ` [PATCH v1 1/2] ipconfig: Do not filter out 0.0.0.0 gateway routes Daniel Wagner
2022-12-18 19:28 ` [PATCH v1 2/2] main: Add Hamachi interface to ignore list Daniel Wagner
@ 2023-01-02 8:16 ` Daniel Wagner
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Wagner @ 2023-01-02 8:16 UTC (permalink / raw)
To: connman; +Cc: Geoffrey Van Landeghem, i . Dark_Templar
On Sun, Dec 18, 2022 at 08:28:18PM +0100, Daniel Wagner wrote:
> A bunch of fixes for the recentently reported regressions:
>
> - https://lore.kernel.org/connman/66993511-8b3c-bf48-beaf-9ff9e6ee446b@gmail.com/T/#u
> - https://lore.kernel.org/connman/b4938292-e2a0-e572-77c1-19dda0a16d0c@dark-templar-archives.net/
>
> Daniel Wagner (2):
> ipconfig: Do not filter out 0.0.0.0 gateway routes
> main: Add Hamachi interface to ignore list
Both patches applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-02 8:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-18 19:28 [PATCH v1 0/2] Fix a couple of regression Daniel Wagner
2022-12-18 19:28 ` [PATCH v1 1/2] ipconfig: Do not filter out 0.0.0.0 gateway routes Daniel Wagner
2022-12-18 19:28 ` [PATCH v1 2/2] main: Add Hamachi interface to ignore list Daniel Wagner
2023-01-02 8:16 ` [PATCH v1 0/2] Fix a couple of regression Daniel Wagner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).