* [PATCH] ipconfig: Demote RTNL RTM_{ADD,DEL}ROUTE logs from info to DBG.
@ 2023-12-21 7:08 Grant Erickson
2023-12-23 12:21 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Grant Erickson @ 2023-12-21 7:08 UTC (permalink / raw)
To: connman
With the "continuous" online check mode, logs can become dominated by
Linux Routing Netlink (rtnl) 'RTM_{ADD,DEL}ROUTE' entries every time
WISPr adds/deletes a host route for the online check.
This demotes those log invocations from 'connman_info' to 'DBG'.
---
src/ipconfig.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 5ec619fa7e6b..c2d7d2bc02b8 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -1102,7 +1102,7 @@ void __connman_ipconfig_newroute(int index, int family, unsigned char scope,
}
}
- connman_info("%s {add} route %s/%u gw %s scope %u <%s> table %u <%s> "
+ DBG("%s {add} route %s/%u gw %s scope %u <%s> table %u <%s> "
"metric %u",
ifname, dst, dst_prefixlen, gateway, scope, scope2str(scope),
table_id, __connman_inet_table2string(table_id), metric);
@@ -1174,7 +1174,7 @@ void __connman_ipconfig_delroute(int index, int family, unsigned char scope,
}
}
- connman_info("%s {del} route %s/%u gw %s scope %u <%s> table %u <%s> "
+ DBG("%s {del} route %s/%u gw %s scope %u <%s> table %u <%s> "
"metric %u",
ifname, dst, dst_prefixlen, gateway, scope, scope2str(scope),
table_id, __connman_inet_table2string(table_id), metric);
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipconfig: Demote RTNL RTM_{ADD,DEL}ROUTE logs from info to DBG.
2023-12-21 7:08 [PATCH] ipconfig: Demote RTNL RTM_{ADD,DEL}ROUTE logs from info to DBG Grant Erickson
@ 2023-12-23 12:21 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2023-12-23 12:21 UTC (permalink / raw)
To: Grant Erickson; +Cc: connman
Hi Grant,
> With the "continuous" online check mode, logs can become dominated by
> Linux Routing Netlink (rtnl) 'RTM_{ADD,DEL}ROUTE' entries every time
> WISPr adds/deletes a host route for the online check.
>
> This demotes those log invocations from 'connman_info' to 'DBG'.
> ---
> src/ipconfig.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
patch has been applied.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-23 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-21 7:08 [PATCH] ipconfig: Demote RTNL RTM_{ADD,DEL}ROUTE logs from info to DBG Grant Erickson
2023-12-23 12:21 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).