[PATCH 0/2] Add Service Identifier to a Couple of 'DBG' Statements

[PATCH 0/2] Add Service Identifier to a Couple of 'DBG' Statements

[Grant Erickson]

This adds the service identifier to the 'DBG' statements in
timeserver.c:'ts_reset' and session.c:'service_state_changed' to aid
debugging in a multi-technology environment with
"EnableOnlineToReadyTransition" asserted and for consistency with
other DBG statements in other modules.

Grant Erickson (2):
  session: Add service identifier to 'DBG' in 'service_state_changed'.
  timeserver: Add service identifier to 'DBG' in 'ts_reset'.

 src/session.c    | 4 +++-
 src/timeserver.c | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)

-- 
2.42.0

[PATCH 1/2] session: Add service identifier to 'DBG' in 'service_state_changed'.

[Grant Erickson]

This adds the service identifier to the 'DBG' statement in
'service_state_changed' to aid debugging in a multi-technology
environment with "EnableOnlineToReadyTransition" asserted and for
consistency with other 'DBG' statements in other modules.
---
 src/session.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/session.c b/src/session.c
index eeefe3f28b3c..bef4b833a3cb 100644
--- a/src/session.c
+++ b/src/session.c
@@ -1937,7 +1937,9 @@ static void service_state_changed(struct connman_service *service,
 {
 	struct connman_service_info *info;
 
-	DBG("service %p state %d", service, state);
+	DBG("service %p (%s) state %d",
+		service, connman_service_get_identifier(service),
+		state);
 
 	info = g_hash_table_lookup(service_hash, service);
 
-- 
2.42.0

[PATCH 2/2] timeserver: Add service identifier to 'DBG' in 'ts_reset'.

[Grant Erickson]

This adds the service identifier to the 'DBG' statement in 'ts_reset'
to aid debugging in a multi-technology environment with
"EnableOnlineToReadyTransition" asserted and for consistency with
other 'DBG' statements in other modules.
---
 src/timeserver.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/timeserver.c b/src/timeserver.c
index 3eb718aa1568..d364f72870c8 100644
--- a/src/timeserver.c
+++ b/src/timeserver.c
@@ -417,7 +417,8 @@ static void ts_set_nameservers(const struct connman_service *service)
  */
 static void ts_reset(struct connman_service *service)
 {
-	DBG("service %p", service);
+	DBG("service %p (%s)",
+		service, connman_service_get_identifier(service));
 
 	if (!resolv)
 		return;
-- 
2.42.0

Re: [PATCH 0/2] Add Service Identifier to a Couple of 'DBG' Statements

[Marcel Holtmann]

Hi Grant,

> This adds the service identifier to the 'DBG' statements in
> timeserver.c:'ts_reset' and session.c:'service_state_changed' to aid
> debugging in a multi-technology environment with
> "EnableOnlineToReadyTransition" asserted and for consistency with
> other DBG statements in other modules.
> 
> Grant Erickson (2):
>  session: Add service identifier to 'DBG' in 'service_state_changed'.
>  timeserver: Add service identifier to 'DBG' in 'ts_reset'.
> 
> src/session.c    | 4 +++-
> src/timeserver.c | 3 ++-
> 2 files changed, 5 insertions(+), 2 deletions(-)

both patches have been applied.

Regards

Marcel