* Re: [RFC connman v1 1/1] gsupplicant: Add support for WPA3-Personal [not found] <20210804212315.265376-1-ariel.dalessandro@collabora.com> @ 2021-08-05 6:07 ` Daniel Wagner 2021-08-05 11:15 ` Ariel D'Alessandro [not found] ` <20210804212315.265376-2-ariel.dalessandro@collabora.com> 1 sibling, 1 reply; 5+ messages in thread From: Daniel Wagner @ 2021-08-05 6:07 UTC (permalink / raw) To: Ariel D'Alessandro; +Cc: connman, iwd, Sven.Dembianny, marcel Hi Ariel, On Wed, Aug 04, 2021 at 06:23:14PM -0300, Ariel D'Alessandro wrote: > Hi all, Daniel: > > WPA3 support has been recently added to connman (wpa_supplicant). As > we've been discussing on a previous thread, this only supports > WPA3-Personal-only mode. > > This RFC patchset adds support for WPA3-Personal transition mode, which > supports both WPA2-Personal (PSK) and WPA3-Personal (SAE). > > Based on the AP accepted key management protocols, connman configures > wpa_supplicant as follows: > > * WPA3-Personal-only mode: key_mgmt="SAE" ; ieee80211w=2 > * WPA3-Personal transition mode: key_mgmt="SAE WPA-PSK" ; ieee80211w=1 > > This patch applies cleanly on top of current master branch (commit > e36a38d8). > > I'd like to hear any thoughts you might have about this. > For reference, see wpa_supplicant configuration [0]. This looks good. If no one speaks up I am going to apply it. Daniel ps: we have a new mailing list (connman@lists.linux.dev). The old one was shutdown. > > Regards, > Ariel D'Alessandro > > [0] https://w1.fi/cgit/hostap/plain/wpa_supplicant/wpa_supplicant.conf > > Ariel D'Alessandro (1): > gsupplicant: Add support for WPA3-Personal transition mode > > gsupplicant/supplicant.c | 29 +++++++++++++++++++---------- > 1 file changed, 19 insertions(+), 10 deletions(-) > > -- > 2.30.2 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC connman v1 1/1] gsupplicant: Add support for WPA3-Personal 2021-08-05 6:07 ` [RFC connman v1 1/1] gsupplicant: Add support for WPA3-Personal Daniel Wagner @ 2021-08-05 11:15 ` Ariel D'Alessandro 2021-09-09 11:10 ` Ariel D'Alessandro 0 siblings, 1 reply; 5+ messages in thread From: Ariel D'Alessandro @ 2021-08-05 11:15 UTC (permalink / raw) To: Daniel Wagner; +Cc: connman, iwd, Sven.Dembianny Hi Daniel, On 8/5/21 3:07 AM, Daniel Wagner wrote: > Hi Ariel, > > On Wed, Aug 04, 2021 at 06:23:14PM -0300, Ariel D'Alessandro wrote: >> Hi all, Daniel: >> >> WPA3 support has been recently added to connman (wpa_supplicant). As >> we've been discussing on a previous thread, this only supports >> WPA3-Personal-only mode. >> >> This RFC patchset adds support for WPA3-Personal transition mode, which >> supports both WPA2-Personal (PSK) and WPA3-Personal (SAE). >> >> Based on the AP accepted key management protocols, connman configures >> wpa_supplicant as follows: >> >> * WPA3-Personal-only mode: key_mgmt="SAE" ; ieee80211w=2 >> * WPA3-Personal transition mode: key_mgmt="SAE WPA-PSK" ; ieee80211w=1 >> >> This patch applies cleanly on top of current master branch (commit >> e36a38d8). >> >> I'd like to hear any thoughts you might have about this. >> For reference, see wpa_supplicant configuration [0]. > > This looks good. If no one speaks up I am going to apply it. Sounds good. > > Daniel > > ps: we have a new mailing list (connman@lists.linux.dev). The old one > was shutdown. Thanks for pointing that out! Ariel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC connman v1 1/1] gsupplicant: Add support for WPA3-Personal 2021-08-05 11:15 ` Ariel D'Alessandro @ 2021-09-09 11:10 ` Ariel D'Alessandro 2021-09-13 6:27 ` Daniel Wagner 0 siblings, 1 reply; 5+ messages in thread From: Ariel D'Alessandro @ 2021-09-09 11:10 UTC (permalink / raw) To: Daniel Wagner; +Cc: connman, iwd, Sven.Dembianny Hi Daniel, On 8/5/21 8:15 AM, Ariel D'Alessandro wrote: > Hi Daniel, > > On 8/5/21 3:07 AM, Daniel Wagner wrote: >> Hi Ariel, >> >> On Wed, Aug 04, 2021 at 06:23:14PM -0300, Ariel D'Alessandro wrote: >>> Hi all, Daniel: >>> >>> WPA3 support has been recently added to connman (wpa_supplicant). As >>> we've been discussing on a previous thread, this only supports >>> WPA3-Personal-only mode. >>> >>> This RFC patchset adds support for WPA3-Personal transition mode, which >>> supports both WPA2-Personal (PSK) and WPA3-Personal (SAE). >>> >>> Based on the AP accepted key management protocols, connman configures >>> wpa_supplicant as follows: >>> >>> * WPA3-Personal-only mode: key_mgmt="SAE" ; ieee80211w=2 >>> * WPA3-Personal transition mode: key_mgmt="SAE WPA-PSK" ; ieee80211w=1 >>> >>> This patch applies cleanly on top of current master branch (commit >>> e36a38d8). >>> >>> I'd like to hear any thoughts you might have about this. >>> For reference, see wpa_supplicant configuration [0]. >> >> This looks good. If no one speaks up I am going to apply it. Any other feedback on this one? Can we merge it? Thanks, Ariel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC connman v1 1/1] gsupplicant: Add support for WPA3-Personal 2021-09-09 11:10 ` Ariel D'Alessandro @ 2021-09-13 6:27 ` Daniel Wagner 0 siblings, 0 replies; 5+ messages in thread From: Daniel Wagner @ 2021-09-13 6:27 UTC (permalink / raw) To: Ariel D'Alessandro; +Cc: connman, iwd, Sven.Dembianny Hi Ariel, [back from holiday :)] On Thu, Sep 09, 2021 at 08:10:10AM -0300, Ariel D'Alessandro wrote: > >> This looks good. If no one speaks up I am going to apply it. > > Any other feedback on this one? Can we merge it? Sure, patch applied. Thanks! Daniel ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20210804212315.265376-2-ariel.dalessandro@collabora.com>]
* Re: [RFC connman v1 1/1] gsupplicant: Add support for WPA3-Personal transition mode [not found] ` <20210804212315.265376-2-ariel.dalessandro@collabora.com> @ 2021-08-05 6:07 ` Daniel Wagner 0 siblings, 0 replies; 5+ messages in thread From: Daniel Wagner @ 2021-08-05 6:07 UTC (permalink / raw) To: Ariel D'Alessandro; +Cc: connman, iwd, Sven.Dembianny, marcel [adding the new mailing list] On Wed, Aug 04, 2021 at 06:23:15PM -0300, Ariel D'Alessandro wrote: > This commit adds support for WPA3-Personal transition mode, which > supports both WPA2-Personal (PSK) and WPA3-Personal (SAE). > > Based on the AP accepted key management protocols, connman configures > wpa_supplicant as follows: > > * WPA3-Personal-only mode: key_mgmt="SAE" ; ieee80211w=2 > * WPA3-Personal transition mode: key_mgmt="SAE WPA-PSK" ; ieee80211w=1 > > Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com> > --- > gsupplicant/supplicant.c | 29 +++++++++++++++++++---------- > 1 file changed, 19 insertions(+), 10 deletions(-) > > diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c > index 58c78fd1..8316f48a 100644 > --- a/gsupplicant/supplicant.c > +++ b/gsupplicant/supplicant.c > @@ -4903,17 +4903,16 @@ static void add_network_security_proto(DBusMessageIter *dict, > g_free(proto); > } > > -static void add_network_ieee80211w(DBusMessageIter *dict, GSupplicantSSID *ssid) > +static void add_network_ieee80211w(DBusMessageIter *dict, GSupplicantSSID *ssid, > + GSupplicantMfpOptions ieee80211w) > { > - if (!(ssid->keymgmt & G_SUPPLICANT_KEYMGMT_SAE)) > - return; > - > supplicant_dbus_dict_append_basic(dict, "ieee80211w", DBUS_TYPE_UINT32, > - &ssid->ieee80211w); > + &ieee80211w); > } > > static void add_network_security(DBusMessageIter *dict, GSupplicantSSID *ssid) > { > + GSupplicantMfpOptions ieee80211w; > char *key_mgmt; > > switch (ssid->security) { > @@ -4929,10 +4928,22 @@ static void add_network_security(DBusMessageIter *dict, GSupplicantSSID *ssid) > add_network_security_ciphers(dict, ssid); > break; > case G_SUPPLICANT_SECURITY_PSK: > - if (ssid->keymgmt & G_SUPPLICANT_KEYMGMT_SAE) > - key_mgmt = "SAE"; > - else > + if (ssid->keymgmt & G_SUPPLICANT_KEYMGMT_SAE) { > + if (ssid->keymgmt & G_SUPPLICANT_KEYMGMT_WPA_PSK) { > + /* > + * WPA3-Personal transition mode: supports both > + * WPA2-Personal (PSK) and WPA3-Personal (SAE) > + */ > + key_mgmt = "SAE WPA-PSK"; > + ieee80211w = G_SUPPLICANT_MFP_OPTIONAL; > + } else { > + key_mgmt = "SAE"; > + ieee80211w = G_SUPPLICANT_MFP_REQUIRED; > + } > + add_network_ieee80211w(dict, ssid, ieee80211w); > + } else { > key_mgmt = "WPA-PSK"; > + } > add_network_security_psk(dict, ssid); > add_network_security_ciphers(dict, ssid); > add_network_security_proto(dict, ssid); > @@ -4994,8 +5005,6 @@ static void interface_add_network_params(DBusMessageIter *iter, void *user_data) > > add_network_security(&dict, ssid); > > - add_network_ieee80211w(&dict, ssid); > - > supplicant_dbus_dict_append_fixed_array(&dict, "ssid", > DBUS_TYPE_BYTE, &ssid->ssid, > ssid->ssid_len); > -- > 2.30.2 > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-13 6:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210804212315.265376-1-ariel.dalessandro@collabora.com>
2021-08-05 6:07 ` [RFC connman v1 1/1] gsupplicant: Add support for WPA3-Personal Daniel Wagner
2021-08-05 11:15 ` Ariel D'Alessandro
2021-09-09 11:10 ` Ariel D'Alessandro
2021-09-13 6:27 ` Daniel Wagner
[not found] ` <20210804212315.265376-2-ariel.dalessandro@collabora.com>
2021-08-05 6:07 ` [RFC connman v1 1/1] gsupplicant: Add support for WPA3-Personal transition mode Daniel Wagner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).