connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
To: 20211015065350.wpf6qqcdfsmvt3q2@beryllium.lan
Cc: Daniel Wagner <wagi@monom.org>, connman@lists.linux.dev
Subject: Re: [PATCH 1/4] tethering: Reduce the number of parameters of tech_set_tethering
Date: Fri, 22 Oct 2021 17:33:28 +0200	[thread overview]
Message-ID: <CAOf5uwmzOsNpSWrneXvHFgEFHWtCEqu4EQ3AXh0Rfa7-fnK2Fg@mail.gmail.com> (raw)
In-Reply-To: <aac98118-9caa-25a9-e41d-eac205624cbb@overkiz.com>

Hi

On Fri, Oct 22, 2021 at 5:20 PM Julien Barrault
<julien.barrault.external@overkiz.com> wrote:
>
> Hi Daniel,
>
> I am using the version 1.39 on which I applied the patch
>
> > Thanks for testing. Could you retest the current HEAD. I've done some
> > stylistic changes, they should not change the patches but who knows :)
>
> I've applied the 4 patches committed on master, but it does not work anymore
>
> There are probably few typos in the patch ("Tethering.Freq" instead of
> "TetheringFreq" in the second patch), but not only (correcting
> Tethering.Freq twice didn't solve the problem)
>
> Unfortunately I didn't have time yet to investigate further, I keep you
> posted if I find what went wrong

Sorry not have time to check them again. I will try to fix them later today

Michael
>
> Julien
>


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

  reply	other threads:[~2021-10-22 15:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 21:30 [PATCH 1/4] tethering: Reduce the number of parameters of tech_set_tethering Michael Trimarchi
2021-10-07 21:30 ` [PATCH 2/4] tethering: Add possibility to configure the access point frequency Michael Trimarchi
2021-10-15  6:52   ` Daniel Wagner
2021-10-15  7:01     ` Michael Nazzareno Trimarchi
2021-10-15  7:04       ` Daniel Wagner
2021-10-15  7:09         ` Michael Nazzareno Trimarchi
2021-10-15  7:18           ` Daniel Wagner
2021-10-07 21:30 ` [PATCH 3/4] tethering: Add TetheringFreq parameter documentation Michael Trimarchi
2021-10-07 21:30 ` [PATCH 4/4] client: Update the connmactl to support optional tethering channel Michael Trimarchi
2021-10-14  6:31 ` [PATCH 1/4] tethering: Reduce the number of parameters of tech_set_tethering Julien Barrault
2021-10-15  6:53   ` Daniel Wagner
2021-10-22 15:20     ` Julien Barrault
2021-10-22 15:33       ` Michael Nazzareno Trimarchi [this message]
2021-10-15  6:51 ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOf5uwmzOsNpSWrneXvHFgEFHWtCEqu4EQ3AXh0Rfa7-fnK2Fg@mail.gmail.com \
    --to=michael@amarulasolutions.com \
    --cc=20211015065350.wpf6qqcdfsmvt3q2@beryllium.lan \
    --cc=connman@lists.linux.dev \
    --cc=wagi@monom.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).