* [PATCH] service: Report errors to user in native mode
@ 2021-10-01 12:20 VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-04 6:34 ` Daniel Wagner
0 siblings, 1 reply; 6+ messages in thread
From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2021-10-01 12:20 UTC (permalink / raw)
To: connman
When the native mode is activated, the user still needs to be informed
of errors in failure state, via the agent.
---
src/service.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/service.c b/src/service.c
index 8097f5373250..70ff26e6a4a1 100644
--- a/src/service.c
+++ b/src/service.c
@@ -6139,7 +6139,8 @@ static int service_indicate_state(struct connman_service *service)
break;
case CONNMAN_SERVICE_STATE_FAILURE:
- if (service->connect_reason == CONNMAN_SERVICE_CONNECT_REASON_USER) {
+ if (service->connect_reason == CONNMAN_SERVICE_CONNECT_REASON_USER ||
+ service->connect_reason == CONNMAN_SERVICE_CONNECT_REASON_NATIVE) {
connman_agent_report_error(service, service->path,
error2string(service->error),
report_error_cb,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] service: Report errors to user in native mode
2021-10-01 12:20 [PATCH] service: Report errors to user in native mode VAUTRIN Emmanuel (Canal Plus Prestataire)
@ 2021-10-04 6:34 ` Daniel Wagner
2021-10-04 8:08 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Wagner @ 2021-10-04 6:34 UTC (permalink / raw)
To: connman, VAUTRIN Emmanuel (Canal Plus Prestataire); +Cc: Daniel Wagner
On Fri, 1 Oct 2021 12:20:27 +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> When the native mode is activated, the user still needs to be informed
> of errors in failure state, via the agent.
>
Applied, thanks!
[1/1] service: Report errors to user in native mode
commit: b9a0a039ccc5697d413f61c9afe7c8c2b6dbd607
Best regards,
--
Daniel Wagner <wagi@monom.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] service: Report errors to user in native mode
2021-10-04 6:34 ` Daniel Wagner
@ 2021-10-04 8:08 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-04 8:41 ` Daniel Wagner
0 siblings, 1 reply; 6+ messages in thread
From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2021-10-04 8:08 UTC (permalink / raw)
To: Daniel Wagner, connman
> Applied, thanks!
Great news for this patch and the others! Thank you Daniel!
Emmanuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] service: Report errors to user in native mode
2021-10-04 8:08 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
@ 2021-10-04 8:41 ` Daniel Wagner
2021-10-04 9:47 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Wagner @ 2021-10-04 8:41 UTC (permalink / raw)
To: VAUTRIN Emmanuel (Canal Plus Prestataire), connman
On 04.10.21 10:08, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
>> Applied, thanks!
> Great news for this patch and the others! Thank you Daniel!
I was blocked doing the stable-rt update, hence I had no cycles left on
ConnMan. Now since the stable-rt release is out the door I try to get
the clang fixes sorted out as next.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] service: Report errors to user in native mode
2021-10-04 8:41 ` Daniel Wagner
@ 2021-10-04 9:47 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-06 12:41 ` Daniel Wagner
0 siblings, 1 reply; 6+ messages in thread
From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2021-10-04 9:47 UTC (permalink / raw)
To: Daniel Wagner, connman
> I was blocked doing the stable-rt update, hence I had no cycles left on
> ConnMan. Now since the stable-rt release is out the door I try to get
> the clang fixes sorted out as next.
Allright, good that you have been able to integrate the 4 patches.
There is no hurry for hidden networks, which is a bit tricky.
I have tried to add the minimal code to support it.
There are probably a lot of codes from wifi.c that still need to be adapted
in iwd.c.
Emmanuel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-06 12:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 12:20 [PATCH] service: Report errors to user in native mode VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-04 6:34 ` Daniel Wagner
2021-10-04 8:08 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-04 8:41 ` Daniel Wagner
2021-10-04 9:47 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-06 12:41 ` Daniel Wagner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).