archive mirror
 help / color / mirror / Atom feed
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)" <>
To: Daniel Wagner <>
Cc: "" <>
Subject: RE: [PATCH] service: Ignore state information in service reordering
Date: Fri, 2 Jul 2021 15:19:28 +0000	[thread overview]
Message-ID: <MRZP264MB154471078FD87663548DE9BB931F9@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210702083720.hwb266z5eo4xlv7f@beryllium.lan>

> So you are saying we should check the order independent of the
> states. Hmm, without VPN Services I'd say you are right, but let me
> think this through with VPN in mind.
Indeed. I have not checked the VPN part.
I will develop my point.
With the following context:
* PreferredTechnologies=ethernet,wifi
* Ethernet (E) unplugged,
* Wifi (W) network connected and online.
when plugging the Ethernet, we have
default_service: W, default_service->state: ONLINE.
new_service: E, new_state: READY
So default_service->state != new_state, the service list
is not updated, as required.
If the state still matters for VPN part, maybe it will be cleaner
to call is_connected() instead of checking the state itself.

Best Regards,


  reply	other threads:[~2021-07-02 15:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23 14:58 [PATCH] service: Ignore state information in service reordering VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-07-02  7:53 ` Daniel Wagner
2021-07-02  8:13   ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-07-02  8:37     ` Daniel Wagner
2021-07-02 15:19       ` VAUTRIN Emmanuel (Canal Plus Prestataire) [this message]
2021-07-06  7:19         ` Daniel Wagner
2021-08-25 12:30           ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-08-29 18:48             ` Daniel Wagner
2021-08-30  7:26               ` VAUTRIN Emmanuel (Canal Plus Prestataire)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MRZP264MB154471078FD87663548DE9BB931F9@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).