containers.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] Documentation: seccomp: Fix typo in user notification
@ 2021-07-02 15:19 Rodrigo Campos
  2021-07-02 15:22 ` Christian Brauner
  2021-07-02 17:40 ` Kees Cook
  0 siblings, 2 replies; 3+ messages in thread
From: Rodrigo Campos @ 2021-07-02 15:19 UTC (permalink / raw)
  To: Kees Cook, Andy Lutomirski, Will Drewry, linux-kernel, containers
  Cc: Alban Crequy, Mauricio Vásquez Bernal, Sargun Dhillon,
	Rodrigo Campos, Christian Brauner

The close on exec flag is O_CLOEXEC, not O_EXEC. This patch just fixes
the typo.

Suggested-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
---
 Documentation/userspace-api/seccomp_filter.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/userspace-api/seccomp_filter.rst b/Documentation/userspace-api/seccomp_filter.rst
index d61219889e49..539e9d4a4860 100644
--- a/Documentation/userspace-api/seccomp_filter.rst
+++ b/Documentation/userspace-api/seccomp_filter.rst
@@ -263,7 +263,7 @@ Userspace can also add file descriptors to the notifying process via
 ``ioctl(SECCOMP_IOCTL_NOTIF_ADDFD)``. The ``id`` member of
 ``struct seccomp_notif_addfd`` should be the same ``id`` as in
 ``struct seccomp_notif``. The ``newfd_flags`` flag may be used to set flags
-like O_EXEC on the file descriptor in the notifying process. If the supervisor
+like O_CLOEXEC on the file descriptor in the notifying process. If the supervisor
 wants to inject the file descriptor with a specific number, the
 ``SECCOMP_ADDFD_FLAG_SETFD`` flag can be used, and set the ``newfd`` member to
 the specific number to use. If that file descriptor is already open in the
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: seccomp: Fix typo in user notification
  2021-07-02 15:19 [PATCH] Documentation: seccomp: Fix typo in user notification Rodrigo Campos
@ 2021-07-02 15:22 ` Christian Brauner
  2021-07-02 17:40 ` Kees Cook
  1 sibling, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2021-07-02 15:22 UTC (permalink / raw)
  To: Rodrigo Campos
  Cc: Kees Cook, Andy Lutomirski, Will Drewry, linux-kernel,
	containers, Alban Crequy, Mauricio Vásquez Bernal,
	Sargun Dhillon

On Fri, Jul 02, 2021 at 05:19:27PM +0200, Rodrigo Campos wrote:
> The close on exec flag is O_CLOEXEC, not O_EXEC. This patch just fixes
> the typo.
> 
> Suggested-by: Christian Brauner <christian.brauner@ubuntu.com>
> Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
> ---

Acked-by: Christian Brauner <christian.brauner@ubuntu.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: seccomp: Fix typo in user notification
  2021-07-02 15:19 [PATCH] Documentation: seccomp: Fix typo in user notification Rodrigo Campos
  2021-07-02 15:22 ` Christian Brauner
@ 2021-07-02 17:40 ` Kees Cook
  1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2021-07-02 17:40 UTC (permalink / raw)
  To: Rodrigo Campos, linux-kernel, containers, Will Drewry, Andy Lutomirski
  Cc: Kees Cook, Mauricio Vásquez Bernal, Christian Brauner,
	Sargun Dhillon, Alban Crequy

On Fri, 2 Jul 2021 17:19:27 +0200, Rodrigo Campos wrote:
> The close on exec flag is O_CLOEXEC, not O_EXEC. This patch just fixes
> the typo.

Applied to for-next/seccomp, thanks!

[1/1] Documentation: seccomp: Fix typo in user notification
      https://git.kernel.org/kees/c/19d67694745c

-- 
Kees Cook


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-02 17:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 15:19 [PATCH] Documentation: seccomp: Fix typo in user notification Rodrigo Campos
2021-07-02 15:22 ` Christian Brauner
2021-07-02 17:40 ` Kees Cook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).