containers.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] ipc: per namespace ipc sysctl changes for v5.19
@ 2022-06-03 17:21 Eric W. Biederman
  2022-06-03 22:59 ` Linus Torvalds
  2022-06-03 23:25 ` pr-tracker-bot
  0 siblings, 2 replies; 4+ messages in thread
From: Eric W. Biederman @ 2022-06-03 17:21 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Alexey Gladkov, Linux Containers


Linus,

Please pull the per-namespace-ipc-sysctls-for-v5.19 tag from the git tree:

  git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git per-namespace-ipc-sysctls-for-v5.19
  HEAD: 38cd5b12b7854941ede1954cf5a2393eb94b5d37 ipc: Remove extra braces

These changes update the ipc sysctls so that they are fundamentally
per ipc namespace.  Previously these sysctls depended upon a hack to
simulate being per ipc namespace by looking up the ipc namespace in
read or write.  With this set of changes the ipc sysctls are
registered per ipc namespace and open looks up the ipc namespace.

Not only does this series of changes ensure the traditional binding at
open time happens, but it sets a foundation for being able to relax the
permission checks to allow a user namspace root to change the ipc sysctls
for an ipc namespace that the user namespace root requires.  To do this
requires the ipc namespace to be known at open time.

These changes were sent for v5.18[1] but were dropped because some
additional cleanups were requested.  Linus has given his nod[2] to the
cleanups so I hope enough cleanups are present this time.

[1] https://lkml.kernel.org/r/877d8kfmdp.fsf@email.froward.int.ebiederm.org
[2] https://lkml.kernel.org/r/CAHk-=whi2SzU4XT_FsdTCAuK2qtYmH+-hwi1cbSdG8zu0KXL=g@mail.gmail.com

Alexey Gladkov (6):
      ipc: Store mqueue sysctls in the ipc namespace
      ipc: Store ipc sysctls in the ipc namespace
      ipc: Use the same namespace to modify and validate
      ipc: Remove extra1 field abuse to pass ipc namespace
      ipc: Check permissions for checkpoint_restart sysctls at open time
      ipc: Remove extra braces


 include/linux/ipc_namespace.h |  37 +++++++-
 ipc/ipc_sysctl.c              | 205 +++++++++++++++++++++++++-----------------
 ipc/mq_sysctl.c               | 121 +++++++++++++------------
 ipc/mqueue.c                  |  10 +--
 ipc/namespace.c               |  10 +++
 5 files changed, 238 insertions(+), 145 deletions(-)

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

p.s. My apologies for this coming in so late.  Everyone in the house has
been sick.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL] ipc: per namespace ipc sysctl changes for v5.19
  2022-06-03 17:21 [GIT PULL] ipc: per namespace ipc sysctl changes for v5.19 Eric W. Biederman
@ 2022-06-03 22:59 ` Linus Torvalds
  2022-06-05 22:11   ` Eric W. Biederman
  2022-06-03 23:25 ` pr-tracker-bot
  1 sibling, 1 reply; 4+ messages in thread
From: Linus Torvalds @ 2022-06-03 22:59 UTC (permalink / raw)
  To: Eric W. Biederman
  Cc: Linux Kernel Mailing List, Alexey Gladkov, Linux Containers

On Fri, Jun 3, 2022 at 10:21 AM Eric W. Biederman <ebiederm@xmission.com> wrote:
>
> These changes were sent for v5.18[1] but were dropped because some
> additional cleanups were requested.  Linus has given his nod[2] to the
> cleanups so I hope enough cleanups are present this time.

Well, I'll be happier still when the next set of cleanups hits:

   https://lore.kernel.org/all/CAHk-=wjJ2CP0ugbOnwAd-=Cw0i-q_xC1PbJ-_1jrvR-aisiAAA@mail.gmail.com/

but yeah, that further cleanup series clearly wasn't quite ready yet.

              Linus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL] ipc: per namespace ipc sysctl changes for v5.19
  2022-06-03 17:21 [GIT PULL] ipc: per namespace ipc sysctl changes for v5.19 Eric W. Biederman
  2022-06-03 22:59 ` Linus Torvalds
@ 2022-06-03 23:25 ` pr-tracker-bot
  1 sibling, 0 replies; 4+ messages in thread
From: pr-tracker-bot @ 2022-06-03 23:25 UTC (permalink / raw)
  To: Eric W. Biederman
  Cc: Linus Torvalds, linux-kernel, Alexey Gladkov, Linux Containers

The pull request you sent on Fri, 03 Jun 2022 12:21:46 -0500:

> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git per-namespace-ipc-sysctls-for-v5.19

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/1888e9b4bb78c88514b24ecafa9e4e4faf761747

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL] ipc: per namespace ipc sysctl changes for v5.19
  2022-06-03 22:59 ` Linus Torvalds
@ 2022-06-05 22:11   ` Eric W. Biederman
  0 siblings, 0 replies; 4+ messages in thread
From: Eric W. Biederman @ 2022-06-05 22:11 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Linux Kernel Mailing List, Alexey Gladkov, Linux Containers

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Fri, Jun 3, 2022 at 10:21 AM Eric W. Biederman <ebiederm@xmission.com> wrote:
>>
>> These changes were sent for v5.18[1] but were dropped because some
>> additional cleanups were requested.  Linus has given his nod[2] to the
>> cleanups so I hope enough cleanups are present this time.
>
> Well, I'll be happier still when the next set of cleanups hits:
>
>    https://lore.kernel.org/all/CAHk-=wjJ2CP0ugbOnwAd-=Cw0i-q_xC1PbJ-_1jrvR-aisiAAA@mail.gmail.com/
>
> but yeah, that further cleanup series clearly wasn't quite ready yet.

Yes.  It came in during the merge window.  I have been keeping a weather
eye on it but I really haven't had a chance to look yet.

Eric

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-05 22:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-03 17:21 [GIT PULL] ipc: per namespace ipc sysctl changes for v5.19 Eric W. Biederman
2022-06-03 22:59 ` Linus Torvalds
2022-06-05 22:11   ` Eric W. Biederman
2022-06-03 23:25 ` pr-tracker-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).