From: Florian Fainelli <f.fainelli@gmail.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Cc: phil@raspberrypi.com, wahrenst@gmx.net, linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH 05/11] soc: bcm: bcm2835-power: Add support for BCM2711's ARSAN ASB
Date: Fri, 5 Feb 2021 08:56:55 -0800 [thread overview]
Message-ID: <d081a505-487d-eb29-94fd-5e1f638bba29@gmail.com> (raw)
In-Reply-To: <20210205135249.2924-6-nsaenzjulienne@suse.de>
On 2/5/21 5:52 AM, Nicolas Saenz Julienne wrote:
> In BCM2711 the new ARGON ASB took over V3D. The old ASB is still present
> with the ISP and H264 bits, and V3D is in the same place in the new ASB
> as the old one.
>
> Use the fact that 'pm->arsan_asb' is populated as a hint that we're on
> BCM2711. On top of that introduce the macro ASB_BASE() which will select
> the correct ASB register base, based on whether we're trying to access
> V3D and which platform we're on.
Your subject has a typo, you most likely intended to write "Argon ASB",
right?
I will review the series a little later today.
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Cc: linux-kernel@vger.kernel.org, phil@raspberrypi.com, wahrenst@gmx.net
Subject: Re: [RFC/PATCH 05/11] soc: bcm: bcm2835-power: Add support for BCM2711's ARSAN ASB
Date: Fri, 5 Feb 2021 08:56:55 -0800 [thread overview]
Message-ID: <d081a505-487d-eb29-94fd-5e1f638bba29@gmail.com> (raw)
In-Reply-To: <20210205135249.2924-6-nsaenzjulienne@suse.de>
On 2/5/21 5:52 AM, Nicolas Saenz Julienne wrote:
> In BCM2711 the new ARGON ASB took over V3D. The old ASB is still present
> with the ISP and H264 bits, and V3D is in the same place in the new ASB
> as the old one.
>
> Use the fact that 'pm->arsan_asb' is populated as a hint that we're on
> BCM2711. On top of that introduce the macro ASB_BASE() which will select
> the correct ASB register base, based on whether we're trying to access
> V3D and which platform we're on.
Your subject has a typo, you most likely intended to write "Argon ASB",
right?
I will review the series a little later today.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-05 19:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 13:52 [RFC/PATCH 00/11] Raspberry PI 4 V3D enablement Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` [RFC/PATCH 01/11] dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-06 11:34 ` Stefan Wahren
2021-02-06 11:34 ` Stefan Wahren
2021-02-05 13:52 ` [RFC/PATCH 02/11] dt-bindings: soc: bcm: brcm,bcm2835-pm: Add support for bcm2711 Nicolas Saenz Julienne
2021-02-05 13:52 ` [RFC/PATCH 02/11] dt-bindings: soc: bcm: brcm, bcm2835-pm: " Nicolas Saenz Julienne
2021-02-06 11:36 ` [RFC/PATCH 02/11] dt-bindings: soc: bcm: brcm,bcm2835-pm: " Stefan Wahren
2021-02-06 11:36 ` Stefan Wahren
2021-02-05 13:52 ` [RFC/PATCH 03/11] ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` [RFC/PATCH 04/11] mfd: bcm2835-pm: Add support for BCM2711 Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` [RFC/PATCH 05/11] soc: bcm: bcm2835-power: Add support for BCM2711's ARSAN ASB Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 16:56 ` Florian Fainelli [this message]
2021-02-05 16:56 ` Florian Fainelli
2021-02-05 18:30 ` Nicolas Saenz Julienne
2021-02-05 18:30 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` [RFC/PATCH 06/11] soc: bcm: bcm2835-power: Bypass power_on/off() calls Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` [RFC/PATCH 07/11] drm/v3d: Get rid of pm code Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` [RFC/PATCH 08/11] drm/v3d: Add support for bcm2711 Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` [RFC/PATCH 09/11] ARM: dts: bcm2711: Enable V3D Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-06 11:50 ` Stefan Wahren
2021-02-06 11:50 ` Stefan Wahren
2021-02-05 13:52 ` [RFC/PATCH 10/11] ARM: configs: Enable DRM_V3D Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
2021-02-05 13:52 ` [RFC/PATCH 11/11] arm64: config: " Nicolas Saenz Julienne
2021-02-05 13:52 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d081a505-487d-eb29-94fd-5e1f638bba29@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.