All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uli v. d. Ohe" <u-v@mailbox.org>
To: Mikhail Khvoinitsky <me@khvoinitsky.org>
Cc: jkosina@suse.com, benjamin.tissoires@redhat.com,
	iam@valdikss.org.ru, jekhor@gmail.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: lenovo: Restrict detection of patched firmware only to USB cptkbd
Date: Sun, 24 Dec 2023 16:51:30 +0100	[thread overview]
Message-ID: <d13694c9-4409-4566-919b-7a577afd583c@mailbox.org> (raw)
In-Reply-To: <CAMMabwPd-m7a+EQV7zb=wU52=P1FkqFU1dg9=gyvaS1EP5tX3Q@mail.gmail.com>

> So this means that the only reliable way is to add a sysfs parameter.
> I'll send a patch.

Thank you for the quick action!

Perhaps it would be possible to modify the firmware further in order to 
facilitate reliable detection of this modified firmware? But for now the 
solution with a sysfs parameter (and defaulting to the workaround) seems 
good.

Best regards,
Uli

  parent reply	other threads:[~2023-12-24 15:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 14:50 [PATCH] HID: lenovo: Add middleclick_workaround sysfs knob for cptkbd Mikhail Khvainitski
2023-09-23 22:58 ` Mikhail Khvainitski
2023-09-23 22:58   ` [PATCH] HID: lenovo: Detect quirk-free fw on cptkbd and stop applying workaround Mikhail Khvainitski
2023-10-04 19:02     ` Jiri Kosina
2023-12-09 12:50     ` Yauhen Kharuzhy
2023-12-09 16:56       ` Yauhen Kharuzhy
2023-12-09 18:21         ` Yauhen Kharuzhy
2023-12-11 16:17           ` Mikhail Khvoinitsky
2023-12-12 13:31             ` [PATCH] HID: lenovo: Restrict detection of patched firmware only to USB cptkbd Mikhail Khvainitski
2023-12-12 13:45               ` Jiri Kosina
2023-12-22 15:32                 ` Uli v. d. Ohe
2023-12-23 18:04                   ` Mikhail Khvoinitsky
2023-12-23 19:12                     ` [PATCH] HID: lenovo: Add middleclick_workaround sysfs knob for cptkbd Mikhail Khvainitski
2024-01-23 10:55                       ` Jiri Kosina
2023-12-24 15:51                     ` Uli v. d. Ohe [this message]
2023-12-26  9:36                       ` [PATCH] HID: lenovo: Restrict detection of patched firmware only to USB cptkbd Yauhen Kharuzhy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d13694c9-4409-4566-919b-7a577afd583c@mailbox.org \
    --to=u-v@mailbox.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=iam@valdikss.org.ru \
    --cc=jekhor@gmail.com \
    --cc=jkosina@suse.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@khvoinitsky.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.