From: Jiri Kosina <jikos@kernel.org>
To: Mikhail Khvainitski <me@khvoinitsky.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
iam@valdikss.org.ru, jekhor@gmail.com, u-v@mailbox.org
Subject: Re: [PATCH] HID: lenovo: Add middleclick_workaround sysfs knob for cptkbd
Date: Tue, 23 Jan 2024 11:55:58 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2401231155270.29548@cbobk.fhfr.pm> (raw)
In-Reply-To: <20231223191401.70727-1-me@khvoinitsky.org>
On Sat, 23 Dec 2023, Mikhail Khvainitski wrote:
> Previous attempt to autodetect well-behaving patched firmware
> introduced in commit 46a0a2c96f0f ("HID: lenovo: Detect quirk-free fw
> on cptkbd and stop applying workaround") has shown that there are
> false-positives on original firmware (on both 1st gen and 2nd gen
> keyboards) which causes the middle button click workaround to be
> mistakenly disabled.
>
> This commit adds explicit parameter to sysfs to control this
> workaround.
>
> Fixes: 46a0a2c96f0f ("HID: lenovo: Detect quirk-free fw on cptkbd and stop applying workaround")
> Fixes: 43527a0094c1 ("HID: lenovo: Restrict detection of patched firmware only to USB cptkbd")
> Signed-off-by: Mikhail Khvainitski <me@khvoinitsky.org>
I am not a huge fan of sysctl device-specific knobs like this, but I guess
this is the best we can get here, unfortunately.
Now applied, thanks a lot.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2024-01-23 10:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 14:50 [PATCH] HID: lenovo: Add middleclick_workaround sysfs knob for cptkbd Mikhail Khvainitski
2023-09-23 22:58 ` Mikhail Khvainitski
2023-09-23 22:58 ` [PATCH] HID: lenovo: Detect quirk-free fw on cptkbd and stop applying workaround Mikhail Khvainitski
2023-10-04 19:02 ` Jiri Kosina
2023-12-09 12:50 ` Yauhen Kharuzhy
2023-12-09 16:56 ` Yauhen Kharuzhy
2023-12-09 18:21 ` Yauhen Kharuzhy
2023-12-11 16:17 ` Mikhail Khvoinitsky
2023-12-12 13:31 ` [PATCH] HID: lenovo: Restrict detection of patched firmware only to USB cptkbd Mikhail Khvainitski
2023-12-12 13:45 ` Jiri Kosina
2023-12-22 15:32 ` Uli v. d. Ohe
2023-12-23 18:04 ` Mikhail Khvoinitsky
2023-12-23 19:12 ` [PATCH] HID: lenovo: Add middleclick_workaround sysfs knob for cptkbd Mikhail Khvainitski
2024-01-23 10:55 ` Jiri Kosina [this message]
2023-12-24 15:51 ` [PATCH] HID: lenovo: Restrict detection of patched firmware only to USB cptkbd Uli v. d. Ohe
2023-12-26 9:36 ` Yauhen Kharuzhy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2401231155270.29548@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=iam@valdikss.org.ru \
--cc=jekhor@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@khvoinitsky.org \
--cc=u-v@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.