From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Eddie Hung <eddie.hung@mediatek.com>
Subject: Re: [PATCH v2 2/7] dt-bindings: phy: mediatek,tphy: add property to set pre-emphasis
Date: Tue, 30 Aug 2022 20:38:10 +0300 [thread overview]
Message-ID: <d1f49935-b465-7495-d345-f35bf4dea9f9@linaro.org> (raw)
In-Reply-To: <20220829080830.5378-2-chunfeng.yun@mediatek.com>
On 29/08/2022 11:08, Chunfeng Yun wrote:
> Add a property to set usb2 phy's pre-emphasis, which used to widen eye
> opening and boost eye swing.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: Add more description suggested by Krzysztof
> ---
> .../devicetree/bindings/phy/mediatek,tphy.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index 848edfb1f677..e0754fb44451 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -219,6 +219,16 @@ patternProperties:
> minimum: 1
> maximum: 15
>
> + mediatek,pre-emphasis:
> + description:
> + The level of pre-emphasis which used to widen the eye opening and
> + boost eye swing, the unit step is about 4.16% increment; e.g. the
> + level 1 means amplitude increases about 4.16%, the level 2 is about
> + 8.3% etc. (U2 phy)
> + $ref: /schemas/types.yaml#/definitions/uint32
As I proposed - use instead common units. Since only three values are
allowed - make it an enum. These bindings are expected to be
usable/applicable on several devices, so units, not register values
which can change between devices, are the proper and reliable way to
describe a feature.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Eddie Hung <eddie.hung@mediatek.com>
Subject: Re: [PATCH v2 2/7] dt-bindings: phy: mediatek,tphy: add property to set pre-emphasis
Date: Tue, 30 Aug 2022 20:38:10 +0300 [thread overview]
Message-ID: <d1f49935-b465-7495-d345-f35bf4dea9f9@linaro.org> (raw)
In-Reply-To: <20220829080830.5378-2-chunfeng.yun@mediatek.com>
On 29/08/2022 11:08, Chunfeng Yun wrote:
> Add a property to set usb2 phy's pre-emphasis, which used to widen eye
> opening and boost eye swing.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: Add more description suggested by Krzysztof
> ---
> .../devicetree/bindings/phy/mediatek,tphy.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index 848edfb1f677..e0754fb44451 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -219,6 +219,16 @@ patternProperties:
> minimum: 1
> maximum: 15
>
> + mediatek,pre-emphasis:
> + description:
> + The level of pre-emphasis which used to widen the eye opening and
> + boost eye swing, the unit step is about 4.16% increment; e.g. the
> + level 1 means amplitude increases about 4.16%, the level 2 is about
> + 8.3% etc. (U2 phy)
> + $ref: /schemas/types.yaml#/definitions/uint32
As I proposed - use instead common units. Since only three values are
allowed - make it an enum. These bindings are expected to be
usable/applicable on several devices, so units, not register values
which can change between devices, are the proper and reliable way to
describe a feature.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Eddie Hung <eddie.hung@mediatek.com>
Subject: Re: [PATCH v2 2/7] dt-bindings: phy: mediatek,tphy: add property to set pre-emphasis
Date: Tue, 30 Aug 2022 20:38:10 +0300 [thread overview]
Message-ID: <d1f49935-b465-7495-d345-f35bf4dea9f9@linaro.org> (raw)
In-Reply-To: <20220829080830.5378-2-chunfeng.yun@mediatek.com>
On 29/08/2022 11:08, Chunfeng Yun wrote:
> Add a property to set usb2 phy's pre-emphasis, which used to widen eye
> opening and boost eye swing.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: Add more description suggested by Krzysztof
> ---
> .../devicetree/bindings/phy/mediatek,tphy.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index 848edfb1f677..e0754fb44451 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -219,6 +219,16 @@ patternProperties:
> minimum: 1
> maximum: 15
>
> + mediatek,pre-emphasis:
> + description:
> + The level of pre-emphasis which used to widen the eye opening and
> + boost eye swing, the unit step is about 4.16% increment; e.g. the
> + level 1 means amplitude increases about 4.16%, the level 2 is about
> + 8.3% etc. (U2 phy)
> + $ref: /schemas/types.yaml#/definitions/uint32
As I proposed - use instead common units. Since only three values are
allowed - make it an enum. These bindings are expected to be
usable/applicable on several devices, so units, not register values
which can change between devices, are the proper and reliable way to
describe a feature.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-30 17:47 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 8:08 [PATCH v2 1/7] dt-bindings: phy: mediatek,tphy: add support type of SGMII Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-29 8:08 ` [PATCH v2 2/7] dt-bindings: phy: mediatek,tphy: add property to set pre-emphasis Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-30 17:38 ` Krzysztof Kozlowski [this message]
2022-08-30 17:38 ` Krzysztof Kozlowski
2022-08-30 17:38 ` Krzysztof Kozlowski
2022-08-31 3:14 ` Chunfeng Yun
2022-08-31 3:14 ` Chunfeng Yun
2022-08-31 3:14 ` Chunfeng Yun
2022-08-31 6:02 ` Krzysztof Kozlowski
2022-08-31 6:02 ` Krzysztof Kozlowski
2022-08-31 6:02 ` Krzysztof Kozlowski
2022-09-09 3:07 ` Chunfeng Yun
2022-09-09 3:07 ` Chunfeng Yun
2022-09-09 3:07 ` Chunfeng Yun
2022-09-09 7:11 ` Krzysztof Kozlowski
2022-09-09 7:11 ` Krzysztof Kozlowski
2022-09-09 7:11 ` Krzysztof Kozlowski
2022-09-09 8:27 ` Krzysztof Kozlowski
2022-09-09 8:27 ` Krzysztof Kozlowski
2022-09-09 8:27 ` Krzysztof Kozlowski
2022-08-29 8:08 ` [PATCH v2 3/7] phy: phy-mtk-tphy: " Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-31 8:14 ` AngeloGioacchino Del Regno
2022-08-31 8:14 ` AngeloGioacchino Del Regno
2022-08-31 8:14 ` AngeloGioacchino Del Regno
2022-09-08 1:39 ` Chunfeng Yun
2022-09-08 1:39 ` Chunfeng Yun
2022-09-08 1:39 ` Chunfeng Yun
2022-09-08 8:05 ` AngeloGioacchino Del Regno
2022-09-08 8:05 ` AngeloGioacchino Del Regno
2022-09-08 8:05 ` AngeloGioacchino Del Regno
2022-09-14 3:22 ` Chunfeng Yun
2022-09-14 3:22 ` Chunfeng Yun
2022-09-14 3:22 ` Chunfeng Yun
2022-08-29 8:08 ` [PATCH v2 4/7] phy: phy-mtk-tphy: disable hardware efuse when set INTR Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-31 8:22 ` AngeloGioacchino Del Regno
2022-08-31 8:22 ` AngeloGioacchino Del Regno
2022-08-31 8:22 ` AngeloGioacchino Del Regno
2022-08-29 8:08 ` [PATCH v2 5/7] phy: phy-mtk-tphy: disable gpio mode for all usb2 phys Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-29 8:08 ` [PATCH v2 6/7] phy: phy-mtk-tphy: set utmi 0 register in init() ops Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-29 8:08 ` [PATCH v2 7/7] phy: phy-mtk-tphy: fix the phy type setting issue Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-29 8:08 ` Chunfeng Yun
2022-08-31 8:31 ` AngeloGioacchino Del Regno
2022-08-31 8:31 ` AngeloGioacchino Del Regno
2022-08-31 8:31 ` AngeloGioacchino Del Regno
2022-09-08 1:27 ` Chunfeng Yun
2022-09-08 1:27 ` Chunfeng Yun
2022-09-08 1:27 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1f49935-b465-7495-d345-f35bf4dea9f9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.hung@mediatek.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.