From: Paolo Bonzini <pbonzini@redhat.com>
To: Maxim Levitsky <mlevitsk@redhat.com>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH 2/2] KVM: use KVM_{GET|SET}_SREGS2 when supported by kvm.
Date: Thu, 1 Apr 2021 18:09:35 +0200 [thread overview]
Message-ID: <d221fa13-8e3b-0666-ff15-8c86d4e08237@redhat.com> (raw)
In-Reply-To: <20210401144545.1031704-3-mlevitsk@redhat.com>
On 01/04/21 16:45, Maxim Levitsky wrote:
> +
> + for (i = 0; i < 4; i++) {
> + sregs.pdptrs[i] = env->pdptrs[i];
> + }
> +
> + sregs.flags = 0;
> + sregs.padding = 0;
> +
> + return kvm_vcpu_ioctl(CPU(cpu), KVM_SET_SREGS2, &sregs);
> +}
> +
This breaks when migrating from old to new kernel, because in that case
the PDPTRs are not initialized.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Maxim Levitsky <mlevitsk@redhat.com>, qemu-devel@nongnu.org
Cc: Cornelia Huck <cohuck@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH 2/2] KVM: use KVM_{GET|SET}_SREGS2 when supported by kvm.
Date: Thu, 1 Apr 2021 18:09:35 +0200 [thread overview]
Message-ID: <d221fa13-8e3b-0666-ff15-8c86d4e08237@redhat.com> (raw)
In-Reply-To: <20210401144545.1031704-3-mlevitsk@redhat.com>
On 01/04/21 16:45, Maxim Levitsky wrote:
> +
> + for (i = 0; i < 4; i++) {
> + sregs.pdptrs[i] = env->pdptrs[i];
> + }
> +
> + sregs.flags = 0;
> + sregs.padding = 0;
> +
> + return kvm_vcpu_ioctl(CPU(cpu), KVM_SET_SREGS2, &sregs);
> +}
> +
This breaks when migrating from old to new kernel, because in that case
the PDPTRs are not initialized.
Paolo
next prev parent reply other threads:[~2021-04-01 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 14:45 [PATCH 0/2] kvm: use KVM_{GET|SET}_SREGS2 when available Maxim Levitsky
2021-04-01 14:45 ` Maxim Levitsky
2021-04-01 14:45 ` [PATCH 1/2] kvm: update kernel headers for KVM_{GET|SET}_SREGS2 Maxim Levitsky
2021-04-01 14:45 ` Maxim Levitsky
2021-04-01 14:45 ` [PATCH 2/2] KVM: use KVM_{GET|SET}_SREGS2 when supported by kvm Maxim Levitsky
2021-04-01 14:45 ` Maxim Levitsky
2021-04-01 16:09 ` Paolo Bonzini [this message]
2021-04-01 16:09 ` Paolo Bonzini
2021-04-01 17:10 ` Maxim Levitsky
2021-04-01 17:10 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d221fa13-8e3b-0666-ff15-8c86d4e08237@redhat.com \
--to=pbonzini@redhat.com \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.