From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Linux MM <linux-mm@kvack.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding
Date: Wed, 22 May 2019 11:11:19 +0530 [thread overview]
Message-ID: <d328ce41-4a65-c35e-72d7-74e722795428@linux.ibm.com> (raw)
In-Reply-To: <CAPcyv4j5Y+AFkbvYjDnfqTdmN_Sq=O0qfGUorgpjAE8Ww7vH=A@mail.gmail.com>
On 5/21/19 9:37 PM, Dan Williams wrote:
> On Tue, May 21, 2019 at 2:51 AM Aneesh Kumar K.V
> <aneesh.kumar@linux.ibm.com> wrote:
....
>>
>> Something like the below (Not tested). I am not sure what we will init the page_size
>> for minor version < 3. This will mark the namespace disabled if the
>> PAGE_SIZE and sizeof(struct page) doesn't match with the values used
>> during namespace create.
>
> Yes, this is on the right track.
>
> I would special-case page_size == 0 as 4096 and page_struct_size == 0
> as 64. If either of those is non-zero then the info-block version
> needs to be revved and it needs to be crafted to make older kernels
> fail to parse it.
>
page_size = SZ_4K implies we fail to enable namesepaces created on ppc64
till now. We do work fine with page_size = PAGE_SIZE. It is a few error
check and pfn_sb->npfns that got wrong values. We do reserve the correct
space for the required pfns even when we recorded wrong pfn_sb->npfs.
> There was an earlier attempt to implement minimum info-block versions here:
>
> https://lore.kernel.org/lkml/155000670159.348031.17631616775326330606.stgit@dwillia2-desk3.amr.corp.intel.com/
>
> ...but that was dropped in favor of the the "sub-section" patches.
>
Ok i will pick that too.
-aneesh
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux MM <linux-mm@kvack.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Oliver O'Halloran" <oohall@gmail.com>
Subject: Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding
Date: Wed, 22 May 2019 11:11:19 +0530 [thread overview]
Message-ID: <d328ce41-4a65-c35e-72d7-74e722795428@linux.ibm.com> (raw)
In-Reply-To: <CAPcyv4j5Y+AFkbvYjDnfqTdmN_Sq=O0qfGUorgpjAE8Ww7vH=A@mail.gmail.com>
On 5/21/19 9:37 PM, Dan Williams wrote:
> On Tue, May 21, 2019 at 2:51 AM Aneesh Kumar K.V
> <aneesh.kumar@linux.ibm.com> wrote:
....
>>
>> Something like the below (Not tested). I am not sure what we will init the page_size
>> for minor version < 3. This will mark the namespace disabled if the
>> PAGE_SIZE and sizeof(struct page) doesn't match with the values used
>> during namespace create.
>
> Yes, this is on the right track.
>
> I would special-case page_size == 0 as 4096 and page_struct_size == 0
> as 64. If either of those is non-zero then the info-block version
> needs to be revved and it needs to be crafted to make older kernels
> fail to parse it.
>
page_size = SZ_4K implies we fail to enable namesepaces created on ppc64
till now. We do work fine with page_size = PAGE_SIZE. It is a few error
check and pfn_sb->npfns that got wrong values. We do reserve the correct
space for the required pfns even when we recorded wrong pfn_sb->npfs.
> There was an earlier attempt to implement minimum info-block versions here:
>
> https://lore.kernel.org/lkml/155000670159.348031.17631616775326330606.stgit@dwillia2-desk3.amr.corp.intel.com/
>
> ...but that was dropped in favor of the the "sub-section" patches.
>
Ok i will pick that too.
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Linux MM <linux-mm@kvack.org>,
Oliver O'Halloran <oohall@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding
Date: Wed, 22 May 2019 11:11:19 +0530 [thread overview]
Message-ID: <d328ce41-4a65-c35e-72d7-74e722795428@linux.ibm.com> (raw)
In-Reply-To: <CAPcyv4j5Y+AFkbvYjDnfqTdmN_Sq=O0qfGUorgpjAE8Ww7vH=A@mail.gmail.com>
On 5/21/19 9:37 PM, Dan Williams wrote:
> On Tue, May 21, 2019 at 2:51 AM Aneesh Kumar K.V
> <aneesh.kumar@linux.ibm.com> wrote:
....
>>
>> Something like the below (Not tested). I am not sure what we will init the page_size
>> for minor version < 3. This will mark the namespace disabled if the
>> PAGE_SIZE and sizeof(struct page) doesn't match with the values used
>> during namespace create.
>
> Yes, this is on the right track.
>
> I would special-case page_size == 0 as 4096 and page_struct_size == 0
> as 64. If either of those is non-zero then the info-block version
> needs to be revved and it needs to be crafted to make older kernels
> fail to parse it.
>
page_size = SZ_4K implies we fail to enable namesepaces created on ppc64
till now. We do work fine with page_size = PAGE_SIZE. It is a few error
check and pfn_sb->npfns that got wrong values. We do reserve the correct
space for the required pfns even when we recorded wrong pfn_sb->npfs.
> There was an earlier attempt to implement minimum info-block versions here:
>
> https://lore.kernel.org/lkml/155000670159.348031.17631616775326330606.stgit@dwillia2-desk3.amr.corp.intel.com/
>
> ...but that was dropped in favor of the the "sub-section" patches.
>
Ok i will pick that too.
-aneesh
next prev parent reply other threads:[~2019-05-22 5:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 2:56 [PATCH] mm/nvdimm: Use correct #defines instead of opencoding Aneesh Kumar K.V
2019-05-14 2:56 ` Aneesh Kumar K.V
2019-05-14 2:56 ` Aneesh Kumar K.V
2019-05-14 3:58 ` Dan Williams
2019-05-14 3:58 ` Dan Williams
2019-05-14 3:58 ` Dan Williams
2019-05-14 4:05 ` Aneesh Kumar K.V
2019-05-14 4:05 ` Aneesh Kumar K.V
2019-05-14 4:05 ` Aneesh Kumar K.V
2019-05-14 4:12 ` Dan Williams
2019-05-14 4:12 ` Dan Williams
2019-05-14 4:12 ` Dan Williams
2019-05-14 4:46 ` Aneesh Kumar K.V
2019-05-14 4:46 ` Aneesh Kumar K.V
2019-05-14 4:46 ` Aneesh Kumar K.V
2019-05-21 7:47 ` Dan Williams
2019-05-21 7:47 ` Dan Williams
2019-05-21 7:47 ` Dan Williams
2019-05-21 9:50 ` Aneesh Kumar K.V
2019-05-21 9:50 ` Aneesh Kumar K.V
2019-05-21 9:50 ` Aneesh Kumar K.V
2019-05-21 14:49 ` Elliott, Robert (Servers)
2019-05-21 16:07 ` Dan Williams
2019-05-21 16:07 ` Dan Williams
2019-05-21 16:07 ` Dan Williams
2019-05-22 5:41 ` Aneesh Kumar K.V [this message]
2019-05-22 5:41 ` Aneesh Kumar K.V
2019-05-22 5:41 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d328ce41-4a65-c35e-72d7-74e722795428@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.