Re: [PATCH] reset: reset-zynqmp: Fixed the argument data type

From: Michal Simek <michal.simek@xilinx.com>
To: Michael Tretter <m.tretter@pengutronix.de>,
	Michal Simek <michal.simek@xilinx.com>
Cc: <linux-kernel@vger.kernel.org>, <monstr@monstr.eu>,
	<git@xilinx.com>,
	"Sai Krishna Potthuri" <lakshmi.sai.krishna.potthuri@xilinx.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	<linux-arm-kernel@lists.infradead.org>, <kernel@pengutronix.de>
Subject: Re: [PATCH] reset: reset-zynqmp: Fixed the argument data type
Date: Wed, 11 Aug 2021 13:29:40 +0200	[thread overview]
Message-ID: <d3bdc4c8-1e31-e1ac-e192-c7bff74eb4af@xilinx.com> (raw)
In-Reply-To: <20210811103621.GA23827@pengutronix.de>

On 8/11/21 12:36 PM, Michael Tretter wrote:
> On Wed, 23 Jun 2021 13:46:20 +0200, Michal Simek wrote:
>> From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
>>
>> This patch changes the data type of the variable 'val' from
>> int to u32.
>>
>> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> Addresses-Coverity: argument of type "int *" is incompatible with parameter of type "u32 *"
>> ---
>>
>>  drivers/reset/reset-zynqmp.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c
>> index daa425e74c96..59dc0ff9af9e 100644
>> --- a/drivers/reset/reset-zynqmp.c
>> +++ b/drivers/reset/reset-zynqmp.c
>> @@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev,
>>  			       unsigned long id)
>>  {
>>  	struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev);
>> -	int val, err;
>> +	int err;
>> +	u32 val;
> 
> The function returns val as int instead of u32. While this shouldn't be a
> problem in this case, maybe there should be an additional check just to be
> sure?

As far as I can tell coverity is not reporting any issue around it.
And when I look at internal of that function in firmware this function
in case of success returns only 0 or 1 that's why I don't think we need
to do anything with it.

Thanks,
Michal