From: Andrew Davis <afd@ti.com> To: Siddharth Vadapalli <s-vadapalli@ti.com>, Peter Rosin <peda@axentia.se> Cc: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>, <robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <gregkh@linuxfoundation.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <c-vankar@ti.com>, <srk@ti.com> Subject: Re: [PATCH v5] arm64: dts: ti: k3-j784s4-main: Fix mux-reg-masks in serdes_ln_ctrl Date: Fri, 16 Feb 2024 09:08:31 -0600 [thread overview] Message-ID: <d3ca964c-7fdd-4ed6-8f9c-348d21e5666c@ti.com> (raw) In-Reply-To: <4abe2bde-1171-4b77-b7bc-49491792a721@ti.com> On 2/15/24 10:56 PM, Siddharth Vadapalli wrote: > On 24/02/13 11:08AM, Andrew Davis wrote: >> On 2/13/24 3:19 AM, Peter Rosin wrote: >>> Hi! >>> >>> 2024-02-13 at 09:03, Siddharth Vadapalli wrote: >>>> From: Chintan Vankar <c-vankar@ti.com> >>>> >>>> Change offset in mux-reg-masks property for serdes_ln_ctrl node >>>> since reg-mux property is used in compatible. >>>> >>>> Fixes: 2765149273f4 ("mux: mmio: use reg property when parent device is not a syscon") >>>> Signed-off-by: Chintan Vankar <c-vankar@ti.com> >>>> Acked-by: Andrew Davis <afd@ti.com> >>>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> >>>> --- > ... > >>>> + mux-reg-masks = <0x0 0x3>, <0x4 0x3>, /* SERDES0 lane0/1 select */ >>>> + <0x8 0x3>, <0xc 0x3>, /* SERDES0 lane2/3 select */ >>>> + <0x10 0x3>, <0x14 0x3>, /* SERDES1 lane0/1 select */ >>>> + <0x18 0x3>, <0x1c 0x3>, /* SERDES1 lane2/3 select */ >>>> + <0x20 0x3>, <0x24 0x3>, /* SERDES2 lane0/1 select */ >>>> + <0x28 0x3>, <0x2c 0x3>; /* SERDES2 lane2/3 select */ >>>> idle-states = <J784S4_SERDES0_LANE0_PCIE1_LANE0>, >>>> <J784S4_SERDES0_LANE1_PCIE1_LANE1>, >>>> <J784S4_SERDES0_LANE2_IP3_UNUSED>, >>> >>> Ouch. I suspect there is a similar problem in >>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi: >>> >>> >>> fss: bus@47000000 { >>> compatible = "simple-bus"; >>> reg = <0x0 0x47000000 0x0 0x100>; >>> #address-cells = <2>; >>> #size-cells = <2>; >>> ranges; >>> >>> hbmc_mux: mux-controller@47000004 { >>> compatible = "reg-mux"; >>> reg = <0x00 0x47000004 0x00 0x2>; >>> #mux-control-cells = <1>; >>> - mux-reg-masks = <0x4 0x2>; /* HBMC select */ >>> + mux-reg-masks = <0x0 0x2>; /* HBMC select */ >>> }; >>> >>> Who knows what non-upstreamed devices and devicetrees are affected? >>> I guess we need to revert 2765149273f4 ("mux: mmio: use reg property >>> when parent device is not a syscon") unless someone sees a sane way >>> to fix this. >> >> There are only two in-tree nodes with "reg-mux" with a reg property: the >> one this patch fixes, and the hbmc_mux you point out, both in TI devices. >> I'd say it is safe to assume we are the only users, and our non-upstreamed >> DTs depend on that patch, reverting it would cause more issues for >> out-of-tree users than just fixing the two broken nodes above. > > Peter, > > Is it alright for this patch to be merged, given Andrew's response above? > The problem with "hbmc_mux" node that you pointed out above could be fixed > by another patch. Please let me know. The hbmc_mux fix is now also posted: https://lore.kernel.org/linux-arm-kernel/20240215141957.13775-1-afd@ti.com/ Andrew > > Regards, > Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Davis <afd@ti.com> To: Siddharth Vadapalli <s-vadapalli@ti.com>, Peter Rosin <peda@axentia.se> Cc: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>, <robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <gregkh@linuxfoundation.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <c-vankar@ti.com>, <srk@ti.com> Subject: Re: [PATCH v5] arm64: dts: ti: k3-j784s4-main: Fix mux-reg-masks in serdes_ln_ctrl Date: Fri, 16 Feb 2024 09:08:31 -0600 [thread overview] Message-ID: <d3ca964c-7fdd-4ed6-8f9c-348d21e5666c@ti.com> (raw) In-Reply-To: <4abe2bde-1171-4b77-b7bc-49491792a721@ti.com> On 2/15/24 10:56 PM, Siddharth Vadapalli wrote: > On 24/02/13 11:08AM, Andrew Davis wrote: >> On 2/13/24 3:19 AM, Peter Rosin wrote: >>> Hi! >>> >>> 2024-02-13 at 09:03, Siddharth Vadapalli wrote: >>>> From: Chintan Vankar <c-vankar@ti.com> >>>> >>>> Change offset in mux-reg-masks property for serdes_ln_ctrl node >>>> since reg-mux property is used in compatible. >>>> >>>> Fixes: 2765149273f4 ("mux: mmio: use reg property when parent device is not a syscon") >>>> Signed-off-by: Chintan Vankar <c-vankar@ti.com> >>>> Acked-by: Andrew Davis <afd@ti.com> >>>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> >>>> --- > ... > >>>> + mux-reg-masks = <0x0 0x3>, <0x4 0x3>, /* SERDES0 lane0/1 select */ >>>> + <0x8 0x3>, <0xc 0x3>, /* SERDES0 lane2/3 select */ >>>> + <0x10 0x3>, <0x14 0x3>, /* SERDES1 lane0/1 select */ >>>> + <0x18 0x3>, <0x1c 0x3>, /* SERDES1 lane2/3 select */ >>>> + <0x20 0x3>, <0x24 0x3>, /* SERDES2 lane0/1 select */ >>>> + <0x28 0x3>, <0x2c 0x3>; /* SERDES2 lane2/3 select */ >>>> idle-states = <J784S4_SERDES0_LANE0_PCIE1_LANE0>, >>>> <J784S4_SERDES0_LANE1_PCIE1_LANE1>, >>>> <J784S4_SERDES0_LANE2_IP3_UNUSED>, >>> >>> Ouch. I suspect there is a similar problem in >>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi: >>> >>> >>> fss: bus@47000000 { >>> compatible = "simple-bus"; >>> reg = <0x0 0x47000000 0x0 0x100>; >>> #address-cells = <2>; >>> #size-cells = <2>; >>> ranges; >>> >>> hbmc_mux: mux-controller@47000004 { >>> compatible = "reg-mux"; >>> reg = <0x00 0x47000004 0x00 0x2>; >>> #mux-control-cells = <1>; >>> - mux-reg-masks = <0x4 0x2>; /* HBMC select */ >>> + mux-reg-masks = <0x0 0x2>; /* HBMC select */ >>> }; >>> >>> Who knows what non-upstreamed devices and devicetrees are affected? >>> I guess we need to revert 2765149273f4 ("mux: mmio: use reg property >>> when parent device is not a syscon") unless someone sees a sane way >>> to fix this. >> >> There are only two in-tree nodes with "reg-mux" with a reg property: the >> one this patch fixes, and the hbmc_mux you point out, both in TI devices. >> I'd say it is safe to assume we are the only users, and our non-upstreamed >> DTs depend on that patch, reverting it would cause more issues for >> out-of-tree users than just fixing the two broken nodes above. > > Peter, > > Is it alright for this patch to be merged, given Andrew's response above? > The problem with "hbmc_mux" node that you pointed out above could be fixed > by another patch. Please let me know. The hbmc_mux fix is now also posted: https://lore.kernel.org/linux-arm-kernel/20240215141957.13775-1-afd@ti.com/ Andrew > > Regards, > Siddharth.
next prev parent reply other threads:[~2024-02-16 15:09 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-13 8:03 [PATCH v5] arm64: dts: ti: k3-j784s4-main: Fix mux-reg-masks in serdes_ln_ctrl Siddharth Vadapalli 2024-02-13 8:03 ` Siddharth Vadapalli 2024-02-13 9:19 ` Peter Rosin 2024-02-13 9:19 ` Peter Rosin 2024-02-13 17:08 ` Andrew Davis 2024-02-13 17:08 ` Andrew Davis 2024-02-16 4:56 ` Siddharth Vadapalli 2024-02-16 4:56 ` Siddharth Vadapalli 2024-02-16 15:08 ` Andrew Davis [this message] 2024-02-16 15:08 ` Andrew Davis 2024-02-26 4:08 ` Vignesh Raghavendra 2024-02-26 4:08 ` Vignesh Raghavendra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d3ca964c-7fdd-4ed6-8f9c-348d21e5666c@ti.com \ --to=afd@ti.com \ --cc=c-vankar@ti.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=kristo@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nm@ti.com \ --cc=peda@axentia.se \ --cc=robh@kernel.org \ --cc=s-vadapalli@ti.com \ --cc=srk@ti.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.