From: Arpitha Raghunandan <98.arpi@gmail.com>
To: Iurii Zaikin <yzaikin@google.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Marco Elver <elver@google.com>, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature
Date: Mon, 26 Oct 2020 23:49:10 +0530 [thread overview]
Message-ID: <d3e31145-9286-a81d-3e76-8f23d6f6211f@gmail.com> (raw)
In-Reply-To: <CAAXuY3q6c3d5kkLOqsG2LBmBYS4d9qRuEeZ2ChpJF1OVTkV5gw@mail.gmail.com>
On 26/10/20 11:41 pm, Iurii Zaikin wrote:
>> +static struct timestamp_expectation test_data[] = {
> Can you mark this and the rest of the hardcoded values as the const they are?
>
Sure, I will make this change for the next version.
WARNING: multiple messages have this Message-ID (diff)
From: Arpitha Raghunandan <98.arpi@gmail.com>
To: Iurii Zaikin <yzaikin@google.com>
Cc: Marco Elver <elver@google.com>, Theodore Ts'o <tytso@mit.edu>,
Brendan Higgins <brendanhiggins@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
KUnit Development <kunit-dev@googlegroups.com>
Subject: Re: [Linux-kernel-mentees] [PATCH v2 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature
Date: Mon, 26 Oct 2020 23:49:10 +0530 [thread overview]
Message-ID: <d3e31145-9286-a81d-3e76-8f23d6f6211f@gmail.com> (raw)
In-Reply-To: <CAAXuY3q6c3d5kkLOqsG2LBmBYS4d9qRuEeZ2ChpJF1OVTkV5gw@mail.gmail.com>
On 26/10/20 11:41 pm, Iurii Zaikin wrote:
>> +static struct timestamp_expectation test_data[] = {
> Can you mark this and the rest of the hardcoded values as the const they are?
>
Sure, I will make this change for the next version.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-26 18:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 15:05 [PATCH v2 1/2] kunit: Support for Parameterized Testing Arpitha Raghunandan
2020-10-23 15:05 ` [Linux-kernel-mentees] " Arpitha Raghunandan
2020-10-23 15:06 ` [PATCH v2 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature Arpitha Raghunandan
2020-10-23 15:06 ` [Linux-kernel-mentees] " Arpitha Raghunandan
2020-10-23 17:33 ` kernel test robot
2020-10-23 17:33 ` kernel test robot
2020-10-26 18:11 ` Iurii Zaikin
2020-10-26 18:11 ` [Linux-kernel-mentees] " Iurii Zaikin via Linux-kernel-mentees
2020-10-26 18:19 ` Arpitha Raghunandan [this message]
2020-10-26 18:19 ` Arpitha Raghunandan
2020-10-23 18:08 ` [PATCH v2 1/2] kunit: Support for Parameterized Testing kernel test robot
2020-10-23 18:08 ` kernel test robot
2020-10-23 18:14 ` kernel test robot
2020-10-23 18:14 ` kernel test robot
2020-10-23 18:48 ` Marco Elver
2020-10-23 18:48 ` [Linux-kernel-mentees] " Marco Elver via Linux-kernel-mentees
2020-10-23 18:56 ` Marco Elver
2020-10-23 18:56 ` [Linux-kernel-mentees] " Marco Elver via Linux-kernel-mentees
2020-10-24 5:23 ` Arpitha Raghunandan
2020-10-24 5:23 ` [Linux-kernel-mentees] " Arpitha Raghunandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3e31145-9286-a81d-3e76-8f23d6f6211f@gmail.com \
--to=98.arpi@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=brendanhiggins@google.com \
--cc=elver@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.