From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Arnd Bergmann <arnd@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
Simtec Linux Team <linux@simtec.co.uk>,
Arnd Bergmann <arnd@arndb.de>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
Hannes Reinecke <hare@suse.de>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 09/21] pata: remove samsung_cf driver
Date: Mon, 24 Oct 2022 07:41:35 +0900 [thread overview]
Message-ID: <d458f39c-9927-33e8-b200-51e7cc09f2df@opensource.wdc.com> (raw)
In-Reply-To: <20221021203329.4143397-9-arnd@kernel.org>
On 10/22/22 05:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This device was only used by the smdk6410 board file that is now
> gone, so the driver can be removed as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Arnd,
This patch does not apply to the for-6.2 branch of libata tree. I can fix
that easily, but I am concerned about the fact that this deletes the
header file include/linux/platform_data/ata-samsung_cf.h, which has some
function declarations for gpio used under arch/arm/mach-s3c. So If I apply
this before you queue the other patches for this driver in for-next, we
may endup with build failures. No ?
> ---
> drivers/ata/Kconfig | 10 -
> drivers/ata/Makefile | 1 -
> drivers/ata/pata_samsung_cf.c | 662 -------------------
> include/linux/platform_data/ata-samsung_cf.h | 31 -
> 4 files changed, 704 deletions(-)
> delete mode 100644 drivers/ata/pata_samsung_cf.c
> delete mode 100644 include/linux/platform_data/ata-samsung_cf.h
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 6b446cfc3455..3b8cb7a29efd 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1136,16 +1136,6 @@ config PATA_RZ1000
>
> If unsure, say N.
>
> -config PATA_SAMSUNG_CF
> - tristate "Samsung SoC PATA support"
> - depends on SAMSUNG_DEV_IDE || COMPILE_TEST
> - select PATA_TIMINGS
> - help
> - This option enables basic support for Samsung's S3C/S5P board
> - PATA controllers via the new ATA layer
> -
> - If unsure, say N.
> -
> config PATA_WINBOND_VLB
> tristate "Winbond W83759A VLB PATA support (Experimental)"
> depends on ISA
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 2cca9f500649..4ee5c0761d90 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM) += pata_platform.o
> obj-$(CONFIG_PATA_OF_PLATFORM) += pata_of_platform.o
> obj-$(CONFIG_PATA_RB532) += pata_rb532_cf.o
> obj-$(CONFIG_PATA_RZ1000) += pata_rz1000.o
> -obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o
>
> obj-$(CONFIG_PATA_PXA) += pata_pxa.o
>
> diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c
> deleted file mode 100644
> index aba1536ddd44..000000000000
> diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h
> deleted file mode 100644
> index fccf969dc4da..000000000000
--
Damien Le Moal
Western Digital Research
WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Arnd Bergmann <arnd@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
Simtec Linux Team <linux@simtec.co.uk>,
Arnd Bergmann <arnd@arndb.de>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
Hannes Reinecke <hare@suse.de>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 09/21] pata: remove samsung_cf driver
Date: Mon, 24 Oct 2022 07:41:35 +0900 [thread overview]
Message-ID: <d458f39c-9927-33e8-b200-51e7cc09f2df@opensource.wdc.com> (raw)
In-Reply-To: <20221021203329.4143397-9-arnd@kernel.org>
On 10/22/22 05:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This device was only used by the smdk6410 board file that is now
> gone, so the driver can be removed as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Arnd,
This patch does not apply to the for-6.2 branch of libata tree. I can fix
that easily, but I am concerned about the fact that this deletes the
header file include/linux/platform_data/ata-samsung_cf.h, which has some
function declarations for gpio used under arch/arm/mach-s3c. So If I apply
this before you queue the other patches for this driver in for-next, we
may endup with build failures. No ?
> ---
> drivers/ata/Kconfig | 10 -
> drivers/ata/Makefile | 1 -
> drivers/ata/pata_samsung_cf.c | 662 -------------------
> include/linux/platform_data/ata-samsung_cf.h | 31 -
> 4 files changed, 704 deletions(-)
> delete mode 100644 drivers/ata/pata_samsung_cf.c
> delete mode 100644 include/linux/platform_data/ata-samsung_cf.h
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 6b446cfc3455..3b8cb7a29efd 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1136,16 +1136,6 @@ config PATA_RZ1000
>
> If unsure, say N.
>
> -config PATA_SAMSUNG_CF
> - tristate "Samsung SoC PATA support"
> - depends on SAMSUNG_DEV_IDE || COMPILE_TEST
> - select PATA_TIMINGS
> - help
> - This option enables basic support for Samsung's S3C/S5P board
> - PATA controllers via the new ATA layer
> -
> - If unsure, say N.
> -
> config PATA_WINBOND_VLB
> tristate "Winbond W83759A VLB PATA support (Experimental)"
> depends on ISA
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 2cca9f500649..4ee5c0761d90 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM) += pata_platform.o
> obj-$(CONFIG_PATA_OF_PLATFORM) += pata_of_platform.o
> obj-$(CONFIG_PATA_RB532) += pata_rb532_cf.o
> obj-$(CONFIG_PATA_RZ1000) += pata_rz1000.o
> -obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o
>
> obj-$(CONFIG_PATA_PXA) += pata_pxa.o
>
> diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c
> deleted file mode 100644
> index aba1536ddd44..000000000000
> diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h
> deleted file mode 100644
> index fccf969dc4da..000000000000
--
Damien Le Moal
Western Digital Research
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-23 22:41 UTC|newest]
Thread overview: 196+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 20:22 [PATCH 00/21] ARM: s3c: clean out obsolete platforms Arnd Bergmann
2022-10-21 20:22 ` Arnd Bergmann
2022-10-21 20:22 ` Arnd Bergmann
2022-10-21 20:22 ` Arnd Bergmann
2022-10-21 20:27 ` [PATCH 01/21] ARM: s3c: remove all s3c24xx support Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-22 20:56 ` Heiko Stübner
2022-10-22 20:56 ` Heiko Stübner
2022-10-24 14:27 ` Arnd Bergmann
2022-10-24 14:27 ` Arnd Bergmann
2022-10-24 15:45 ` Heiko Stübner
2022-10-24 15:45 ` Heiko Stübner
2022-10-24 12:25 ` Krzysztof Kozlowski
2022-10-24 12:25 ` Krzysztof Kozlowski
2022-10-27 23:10 ` Stephen Boyd
2022-10-27 23:10 ` Stephen Boyd
2022-10-21 20:27 ` [PATCH 02/21] ARM: s3c: remove s3c24xx specific hacks Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-21 22:33 ` Wolfram Sang
2022-10-21 22:33 ` Wolfram Sang
2022-10-21 22:33 ` Wolfram Sang
2022-10-22 11:24 ` Greg Kroah-Hartman
2022-10-22 11:24 ` Greg Kroah-Hartman
2022-10-22 11:24 ` Greg Kroah-Hartman
2022-10-22 14:02 ` Linus Walleij
2022-10-22 14:02 ` Linus Walleij
2022-10-22 14:02 ` Linus Walleij
2022-10-23 11:00 ` Jonathan Cameron
2022-10-23 11:00 ` Jonathan Cameron
2022-10-23 11:00 ` Jonathan Cameron
2022-10-23 18:08 ` Daniel Lezcano
2022-10-23 18:08 ` Daniel Lezcano
2022-10-23 18:08 ` Daniel Lezcano
2022-10-24 7:55 ` Miquel Raynal
2022-10-24 7:55 ` Miquel Raynal
2022-10-24 7:55 ` Miquel Raynal
2022-10-24 12:26 ` Krzysztof Kozlowski
2022-10-24 12:26 ` Krzysztof Kozlowski
2022-10-24 12:26 ` Krzysztof Kozlowski
2022-10-24 16:53 ` Ulf Hansson
2022-10-24 16:53 ` Ulf Hansson
2022-10-24 16:53 ` Ulf Hansson
2022-10-27 23:10 ` Stephen Boyd
2022-10-27 23:10 ` Stephen Boyd
2022-10-27 23:10 ` Stephen Boyd
2022-10-21 20:27 ` [PATCH 03/21] ARM: s3c: remove most s3c64xx board support Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:26 ` Krzysztof Kozlowski
2022-10-24 12:26 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 04/21] ARM: s3c: remove adc.c Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 11:37 ` Mark Brown
2022-10-24 11:37 ` Mark Brown
2022-10-24 12:27 ` Krzysztof Kozlowski
2022-10-24 12:27 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 05/21] ARM: s3c: simplify platform code Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 11:41 ` Mark Brown
2022-10-24 11:41 ` Mark Brown
2022-10-24 12:29 ` Krzysztof Kozlowski
2022-10-24 12:29 ` Krzysztof Kozlowski
2022-10-24 13:32 ` Arnd Bergmann
2022-10-24 13:32 ` Arnd Bergmann
2022-10-24 14:13 ` Krzysztof Kozlowski
2022-10-24 14:13 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 06/21] ARM: s3c: remove s3c6400 support Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:30 ` Krzysztof Kozlowski
2022-10-24 12:30 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 07/21] power: remove s3c adc battery driver Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 7:28 ` Lee Jones
2022-10-24 7:28 ` Lee Jones
2022-10-24 7:42 ` Arnd Bergmann
2022-10-24 7:42 ` Arnd Bergmann
2022-10-24 7:57 ` Lee Jones
2022-10-24 7:57 ` Lee Jones
2022-10-24 12:31 ` Krzysztof Kozlowski
2022-10-24 12:31 ` Krzysztof Kozlowski
2022-10-28 14:18 ` Sebastian Reichel
2022-10-28 14:18 ` Sebastian Reichel
2022-10-21 20:27 ` [PATCH 08/21] hwmon: remove s3c driver Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-22 4:02 ` Guenter Roeck
2022-10-22 4:02 ` Guenter Roeck
2022-10-22 8:36 ` Arnd Bergmann
2022-10-22 8:36 ` Arnd Bergmann
2022-10-24 12:31 ` Krzysztof Kozlowski
2022-10-24 12:31 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 09/21] pata: remove samsung_cf driver Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-23 14:35 ` Sergey Shtylyov
2022-10-23 14:35 ` Sergey Shtylyov
2022-10-23 22:41 ` Damien Le Moal [this message]
2022-10-23 22:41 ` Damien Le Moal
2022-10-23 22:43 ` Damien Le Moal
2022-10-23 22:43 ` Damien Le Moal
2022-10-24 14:24 ` Arnd Bergmann
2022-10-24 14:24 ` Arnd Bergmann
2022-10-24 12:34 ` Krzysztof Kozlowski
2022-10-24 12:34 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 10/21] mmc: remove s3cmci driver Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:35 ` Krzysztof Kozlowski
2022-10-24 12:35 ` Krzysztof Kozlowski
2022-10-24 16:52 ` Ulf Hansson
2022-10-24 16:52 ` Ulf Hansson
2022-10-21 20:27 ` [PATCH 11/21] clk: remove s3c24xx driver Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-22 11:50 ` Chanwoo Choi
2022-10-22 11:50 ` Chanwoo Choi
2022-10-24 12:37 ` Krzysztof Kozlowski
2022-10-24 12:37 ` Krzysztof Kozlowski
2022-10-27 23:11 ` Stephen Boyd
2022-10-27 23:11 ` Stephen Boyd
2022-10-21 20:27 ` [PATCH 12/21] leds: " Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-22 10:04 ` Pavel Machek
2022-10-22 10:04 ` Pavel Machek
2022-10-24 12:37 ` Krzysztof Kozlowski
2022-10-24 12:37 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 13/21] usb: gadget: remove s3c24xx drivers Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:39 ` Krzysztof Kozlowski
2022-10-24 12:39 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 14/21] dmaengine: remove s3c24xx driver Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:40 ` Krzysztof Kozlowski
2022-10-24 12:40 ` Krzysztof Kozlowski
2022-11-04 14:14 ` Vinod Koul
2022-11-04 14:14 ` Vinod Koul
2022-11-18 21:54 ` [PATCH] ARM: s3c: Fix a build error after the s3c24xx dma driver was removed Uwe Kleine-König
2022-11-20 10:31 ` Krzysztof Kozlowski
2022-11-20 11:22 ` Krzysztof Kozlowski
2022-11-25 8:51 ` Uwe Kleine-König
2022-11-25 8:52 ` Krzysztof Kozlowski
2022-12-02 11:20 ` Regression in dmaengine/next " Uwe Kleine-König
2022-12-02 11:42 ` Vinod Koul
2022-12-05 8:56 ` Uwe Kleine-König
2022-10-21 20:27 ` [PATCH 15/21] cpufreq: remove s3c24xx drivers Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:40 ` Krzysztof Kozlowski
2022-10-24 12:40 ` Krzysztof Kozlowski
2022-10-25 5:19 ` Viresh Kumar
2022-10-25 5:19 ` Viresh Kumar
2022-10-21 20:27 ` [PATCH 16/21] fbdev: remove s3c2410 framebuffer Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:49 ` Krzysztof Kozlowski
2022-10-24 12:49 ` Krzysztof Kozlowski
2022-10-24 12:49 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 17/21] input: remove s3c24xx touchscreen driver Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 11:57 ` Dmitry Torokhov
2022-10-24 11:57 ` Dmitry Torokhov
2022-10-24 12:50 ` Krzysztof Kozlowski
2022-10-24 12:50 ` Krzysztof Kozlowski
2022-10-24 13:02 ` Arnd Bergmann
2022-10-24 13:02 ` Arnd Bergmann
2022-10-21 20:27 ` [PATCH 18/21] pinctrl: remove s3c24xx driver Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-21 21:25 ` Linus Walleij
2022-10-21 21:25 ` Linus Walleij
2022-10-24 12:51 ` Krzysztof Kozlowski
2022-10-24 12:51 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 19/21] spi: " Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:52 ` Krzysztof Kozlowski
2022-10-24 12:52 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 20/21] soc: s3c: remove pm-debug hack Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:52 ` Krzysztof Kozlowski
2022-10-24 12:52 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 21/21] ASoC: samsung: remove unused drivers Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:53 ` Krzysztof Kozlowski
2022-10-24 12:53 ` Krzysztof Kozlowski
2022-10-24 12:53 ` Krzysztof Kozlowski
2022-10-22 15:18 ` [PATCH 00/21] ARM: s3c: clean out obsolete platforms Krzysztof Kozlowski
2022-10-22 15:18 ` Krzysztof Kozlowski
2022-10-22 15:18 ` Krzysztof Kozlowski
2022-10-22 15:18 ` Krzysztof Kozlowski
2022-10-22 19:48 ` Arnd Bergmann
2022-10-22 19:48 ` Arnd Bergmann
2022-10-22 19:48 ` Arnd Bergmann
2022-10-22 19:48 ` Arnd Bergmann
2022-10-24 13:00 ` Rob Herring
2022-10-24 13:00 ` Rob Herring
2022-10-24 13:00 ` Rob Herring
2022-10-24 13:00 ` Rob Herring
2022-10-24 13:18 ` Arnd Bergmann
2022-10-24 13:18 ` Arnd Bergmann
2022-10-24 13:18 ` Arnd Bergmann
2022-10-24 13:18 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d458f39c-9927-33e8-b200-51e7cc09f2df@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ben-linux@fluff.org \
--cc=hare@suse.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@simtec.co.uk \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.