From: Matthieu Baerts <matthieu.baerts at tessares.net>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net] mptcp: provide rmem[0] limit
Date: Mon, 09 Nov 2020 18:20:50 +0100 [thread overview]
Message-ID: <d49c966b-e2fe-e0c9-49ea-a7a2475f45cf@tessares.net> (raw)
In-Reply-To: 37af798bd46f402fb7c79f57ebbdd00614f5d7fa.1604861097.git.pabeni@redhat.com
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Hi Paolo,
On 08/11/2020 19:49, Paolo Abeni wrote:
> The mptcp proto struct currently does not provide the
> required limit for forward memory scheduling. Under
> pressure sk_rmem_schedule() will unconditionally try
> to use such field and will oops.
>
> Address the issue inheriting the tcp limit, as we already
> do for the wmem one.
>
> Fixes: ("mptcp: add missing memory scheduling in the rx path")
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
Good catch, thank you for this patch!
Reviewed-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
WARNING: multiple messages have this Message-ID (diff)
From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
mptcp@lists.01.org
Subject: Re: [MPTCP] [PATCH net] mptcp: provide rmem[0] limit
Date: Mon, 9 Nov 2020 18:20:50 +0100 [thread overview]
Message-ID: <d49c966b-e2fe-e0c9-49ea-a7a2475f45cf@tessares.net> (raw)
In-Reply-To: <37af798bd46f402fb7c79f57ebbdd00614f5d7fa.1604861097.git.pabeni@redhat.com>
Hi Paolo,
On 08/11/2020 19:49, Paolo Abeni wrote:
> The mptcp proto struct currently does not provide the
> required limit for forward memory scheduling. Under
> pressure sk_rmem_schedule() will unconditionally try
> to use such field and will oops.
>
> Address the issue inheriting the tcp limit, as we already
> do for the wmem one.
>
> Fixes: ("mptcp: add missing memory scheduling in the rx path")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Good catch, thank you for this patch!
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next reply other threads:[~2020-11-09 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 17:20 Matthieu Baerts [this message]
2020-11-09 17:20 ` [MPTCP] [PATCH net] mptcp: provide rmem[0] limit Matthieu Baerts
-- strict thread matches above, loose matches on Subject: below --
2020-11-10 1:36 [MPTCP] " Jakub Kicinski
2020-11-10 1:36 ` [MPTCP] " Jakub Kicinski
2020-11-08 18:49 Paolo Abeni
2020-11-08 18:49 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d49c966b-e2fe-e0c9-49ea-a7a2475f45cf@tessares.net \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.