From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: Grygorii Strashko <grygorii.strashko@ti.com>, Vinod Koul <vkoul@kernel.org>, Dan Williams <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org> Cc: Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>, Vignesh Raghavendra <vigneshr@ti.com>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] dmaengine: ti: k3-psil: fix deadlock on error path Date: Thu, 9 Apr 2020 09:45:14 +0300 [thread overview] Message-ID: <d4a71f25-8a25-76bc-bbf7-749e20268339@ti.com> (raw) In-Reply-To: <20200408185501.30776-1-grygorii.strashko@ti.com> On 08/04/2020 21.55, Grygorii Strashko wrote: > The mutex_unlock() is missed on error path of psil_get_ep_config() > which causes deadlock, so add missed mutex_unlock(). Ah, you are right, thanks for catching it! Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > Fixes: 8c6bb62f6b4a ("dmaengine: ti: k3 PSI-L remote endpoint configuration") > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > drivers/dma/ti/k3-psil.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/ti/k3-psil.c b/drivers/dma/ti/k3-psil.c > index d7b965049ccb..fb7c8150b0d1 100644 > --- a/drivers/dma/ti/k3-psil.c > +++ b/drivers/dma/ti/k3-psil.c > @@ -27,6 +27,7 @@ struct psil_endpoint_config *psil_get_ep_config(u32 thread_id) > soc_ep_map = &j721e_ep_map; > } else { > pr_err("PSIL: No compatible machine found for map\n"); > + mutex_unlock(&ep_map_mutex); > return ERR_PTR(-ENOTSUPP); > } > pr_debug("%s: Using map for %s\n", __func__, soc_ep_map->name); > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: Grygorii Strashko <grygorii.strashko@ti.com>, Vinod Koul <vkoul@kernel.org>, Dan Williams <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org> Cc: Sekhar Nori <nsekhar@ti.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vignesh Raghavendra <vigneshr@ti.com> Subject: Re: [PATCH] dmaengine: ti: k3-psil: fix deadlock on error path Date: Thu, 9 Apr 2020 09:45:14 +0300 [thread overview] Message-ID: <d4a71f25-8a25-76bc-bbf7-749e20268339@ti.com> (raw) In-Reply-To: <20200408185501.30776-1-grygorii.strashko@ti.com> On 08/04/2020 21.55, Grygorii Strashko wrote: > The mutex_unlock() is missed on error path of psil_get_ep_config() > which causes deadlock, so add missed mutex_unlock(). Ah, you are right, thanks for catching it! Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > Fixes: 8c6bb62f6b4a ("dmaengine: ti: k3 PSI-L remote endpoint configuration") > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > drivers/dma/ti/k3-psil.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/ti/k3-psil.c b/drivers/dma/ti/k3-psil.c > index d7b965049ccb..fb7c8150b0d1 100644 > --- a/drivers/dma/ti/k3-psil.c > +++ b/drivers/dma/ti/k3-psil.c > @@ -27,6 +27,7 @@ struct psil_endpoint_config *psil_get_ep_config(u32 thread_id) > soc_ep_map = &j721e_ep_map; > } else { > pr_err("PSIL: No compatible machine found for map\n"); > + mutex_unlock(&ep_map_mutex); > return ERR_PTR(-ENOTSUPP); > } > pr_debug("%s: Using map for %s\n", __func__, soc_ep_map->name); > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-09 6:45 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-08 18:55 [PATCH] dmaengine: ti: k3-psil: fix deadlock on error path Grygorii Strashko 2020-04-08 18:55 ` Grygorii Strashko 2020-04-09 6:45 ` Peter Ujfalusi [this message] 2020-04-09 6:45 ` Peter Ujfalusi 2020-04-15 16:05 ` Vinod Koul 2020-04-15 16:05 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d4a71f25-8a25-76bc-bbf7-749e20268339@ti.com \ --to=peter.ujfalusi@ti.com \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=grygorii.strashko@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nsekhar@ti.com \ --cc=vigneshr@ti.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.