Re: [PATCH 1/5] arm64: dts: qcom: sdm845-db845c: drop power-domains from CCI I2C sensors

From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Loic Poulain <loic.poulain@linaro.org>,
	Robert Foss <robert.foss@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: corbet@lwn.net
Subject: Re: [PATCH 1/5] arm64: dts: qcom: sdm845-db845c: drop power-domains from CCI I2C sensors
Date: Wed, 3 Aug 2022 17:46:31 +0200	[thread overview]
Message-ID: <d5a35d28-3b4e-c763-a1fb-89aa3dae6fd2@somainline.org> (raw)
In-Reply-To: <20220802153947.44457-2-krzysztof.kozlowski@linaro.org>


On 2.08.2022 17:39, Krzysztof Kozlowski wrote:
> The Camera Control Interface I2C controller device node belongs to
> TITAN_TOP_GDSC power domain, so its children do not need to specify it
> again.  The OV7251 and OV8856 camera sensor bindings do not allow
> power-domains.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Not tested on hardware.
> ---
Not tested on hardware either, but looks good.

Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Konrad
>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index c6e2c571b452..b9304f81290a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -1228,8 +1228,6 @@ camera@10 {
>  		 * both have to be enabled through the power management
>  		 * gpios.
>  		 */
> -		power-domains = <&clock_camcc TITAN_TOP_GDSC>;
> -
>  		dovdd-supply = <&vreg_lvs1a_1p8>;
>  		avdd-supply = <&cam0_avdd_2v8>;
>  		dvdd-supply = <&cam0_dvdd_1v2>;
> @@ -1273,8 +1271,6 @@ camera@60 {
>  		 *
>  		 * No 1.2V vddd-supply regulator is used.
>  		 */
> -		power-domains = <&clock_camcc TITAN_TOP_GDSC>;
> -
>  		vdddo-supply = <&vreg_lvs1a_1p8>;
>  		vdda-supply = <&cam3_avdd_2v8>;
>