From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Loic Poulain <loic.poulain@linaro.org>,
Robert Foss <robert.foss@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: corbet@lwn.net
Subject: Re: [PATCH 4/5] ARM: dts: qcom: use GPIO flags for tlmm
Date: Wed, 3 Aug 2022 17:35:39 +0200 [thread overview]
Message-ID: <e53cee9d-8eb8-6f8c-4b88-5dedb394a758@somainline.org> (raw)
In-Reply-To: <20220802153947.44457-5-krzysztof.kozlowski@linaro.org>
On 2.08.2022 17:39, Krzysztof Kozlowski wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs. Include
> gpio.h header if this is first usage of that flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm/boot/dts/qcom-apq8074-dragonboard.dts | 3 ++-
> arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 3 ++-
> arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 4 ++--
> arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dts | 5 +++--
> arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +-
> 5 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> index 3051a861ff0c..91716298ec5e 100644
> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> @@ -1,4 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0
> +#include <dt-bindings/gpio/gpio.h>
> #include "qcom-msm8974.dtsi"
> #include "qcom-pm8841.dtsi"
> #include "qcom-pm8941.dtsi"
> @@ -261,7 +262,7 @@ &sdhc_1 {
> &sdhc_2 {
> status = "okay";
>
> - cd-gpios = <&tlmm 62 0x1>;
> + cd-gpios = <&tlmm 62 GPIO_ACTIVE_LOW>;
> vmmc-supply = <&pm8941_l21>;
> vqmmc-supply = <&pm8941_l13>;
>
> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
> index 03bb9e1768c4..0505270cf508 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
> @@ -14,6 +14,7 @@
> *
> */
>
> +#include <dt-bindings/gpio/gpio.h>
> #include "qcom-ipq4019.dtsi"
>
> / {
> @@ -72,7 +73,7 @@ spi@78b5000 {
> pinctrl-0 = <&spi_0_pins>;
> pinctrl-names = "default";
> status = "okay";
> - cs-gpios = <&tlmm 54 0>;
> + cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
>
> mx25l25635e@0 {
> #address-cells = <1>;
> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
> index 44a9597d8bfd..c2f5222e72de 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
> @@ -87,7 +87,7 @@ spi@78b5000 { /* BLSP1 QUP1 */
> pinctrl-0 = <&spi_0_pins>;
> pinctrl-names = "default";
> status = "okay";
> - cs-gpios = <&tlmm 12 0>;
> + cs-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>;
>
> flash@0 {
> #address-cells = <1>;
> @@ -100,7 +100,7 @@ flash@0 {
>
> pci@40000000 {
> status = "okay";
> - perst-gpio = <&tlmm 38 0x1>;
> + perst-gpio = <&tlmm 38 GPIO_ACTIVE_LOW>;
> };
>
> qpic-nand@79b0000 {
> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dts b/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dts
> index c7a6e77da272..7fc33149060c 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dts
> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dts
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> // Copyright (c) 2018, The Linux Foundation. All rights reserved.
>
> +#include <dt-bindings/gpio/gpio.h>
> #include "qcom-ipq4019-ap.dk07.1.dtsi"
>
> / {
> @@ -10,7 +11,7 @@ / {
> soc {
> pci@40000000 {
> status = "okay";
> - perst-gpio = <&tlmm 38 0x1>;
> + perst-gpio = <&tlmm 38 GPIO_ACTIVE_LOW>;
> };
>
> spi@78b6000 {
> @@ -50,7 +51,7 @@ spi@78b5000 {
> pinctrl-0 = <&spi_0_pins>;
> pinctrl-names = "default";
> status = "okay";
> - cs-gpios = <&tlmm 12 0>;
> + cs-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>;
>
> flash@0 {
> #address-cells = <1>;
> diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> index ec5d340562b6..6daceaa87802 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -175,7 +175,7 @@ i2c-gate {
> ak8963@f {
> compatible = "asahi-kasei,ak8963";
> reg = <0x0f>;
> - gpios = <&tlmm 67 0>;
> + gpios = <&tlmm 67 GPIO_ACTIVE_HIGH>;
> vid-supply = <&pm8941_lvs1>;
> vdd-supply = <&pm8941_l17>;
> };
next prev parent reply other threads:[~2022-08-03 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 15:39 [PATCH 0/5] i2c/arm: dt-bindings: qcom: qcom,i2c-cci: convert to dtschema Krzysztof Kozlowski
2022-08-02 15:39 ` [PATCH 1/5] arm64: dts: qcom: sdm845-db845c: drop power-domains from CCI I2C sensors Krzysztof Kozlowski
2022-08-03 15:46 ` Konrad Dybcio
2022-08-02 15:39 ` [PATCH 2/5] arm64: dts: qcom: sdm845-db845c: drop gpios " Krzysztof Kozlowski
2022-08-29 14:26 ` Robert Foss
2022-08-02 15:39 ` [PATCH 3/5] arm64: dts: qcom: use GPIO flags for tlmm Krzysztof Kozlowski
2022-08-03 15:36 ` Konrad Dybcio
2022-08-02 15:39 ` [PATCH 4/5] ARM: " Krzysztof Kozlowski
2022-08-03 15:35 ` Konrad Dybcio [this message]
2022-08-02 15:39 ` [PATCH 5/5] dt-bindings: i2c: qcom,i2c-cci: convert to dtschema Krzysztof Kozlowski
2022-08-03 23:29 ` Rob Herring
2022-08-11 12:24 ` Wolfram Sang
2022-08-29 23:45 ` (subset) [PATCH 0/5] i2c/arm: dt-bindings: qcom: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e53cee9d-8eb8-6f8c-4b88-5dedb394a758@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.