Re: [PATCH 08/19] drm/amd/display/dc/dce80/dce80_resource: Make local functions static

From: Harry Wentland <harry.wentland@amd.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, "Leo Li" <sunpeng.li@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Anthony Koo" <Anthony.Koo@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 08/19] drm/amd/display/dc/dce80/dce80_resource: Make local functions static
Date: Fri, 19 Mar 2021 14:25:04 -0400	[thread overview]
Message-ID: <d6248118-efb2-90dd-cf40-9cdff742a147@amd.com> (raw)
In-Reply-To: <20210319082428.3294591-9-lee.jones@linaro.org>


On 2021-03-19 4:24 a.m., Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:527:17: warning: no previous prototype for ‘dce80_aux_engine_create’ [-Wmissing-prototypes]
>   drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:565:20: warning: no previous prototype for ‘dce80_i2c_hw_create’ [-Wmissing-prototypes]
>   drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:581:20: warning: no previous prototype for ‘dce80_i2c_sw_create’ [-Wmissing-prototypes]
>   drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:715:22: warning: no previous prototype for ‘dce80_link_encoder_create’ [-Wmissing-prototypes]
>   drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:754:22: warning: no previous prototype for ‘dce80_clock_source_create’ [-Wmissing-prototypes]
>   drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:778:6: warning: no previous prototype for ‘dce80_clock_source_destroy’ [-Wmissing-prototypes]
>   drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:868:6: warning: no previous prototype for ‘dce80_validate_bandwidth’ [-Wmissing-prototypes]
>   drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:913:16: warning: no previous prototype for ‘dce80_validate_global’ [-Wmissing-prototypes]
> 
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Anthony Koo <Anthony.Koo@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>   .../drm/amd/display/dc/dce80/dce80_resource.c    | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> index 612450f992782..725d92e40cd30 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> @@ -526,7 +526,7 @@ static struct output_pixel_processor *dce80_opp_create(
>   	return &opp->base;
>   }
>   
> -struct dce_aux *dce80_aux_engine_create(
> +static struct dce_aux *dce80_aux_engine_create(
>   	struct dc_context *ctx,
>   	uint32_t inst)
>   {
> @@ -564,7 +564,7 @@ static const struct dce_i2c_mask i2c_masks = {
>   		I2C_COMMON_MASK_SH_LIST_DCE_COMMON_BASE(_MASK)
>   };
>   
> -struct dce_i2c_hw *dce80_i2c_hw_create(
> +static struct dce_i2c_hw *dce80_i2c_hw_create(
>   	struct dc_context *ctx,
>   	uint32_t inst)
>   {
> @@ -580,7 +580,7 @@ struct dce_i2c_hw *dce80_i2c_hw_create(
>   	return dce_i2c_hw;
>   }
>   
> -struct dce_i2c_sw *dce80_i2c_sw_create(
> +static struct dce_i2c_sw *dce80_i2c_sw_create(
>   	struct dc_context *ctx)
>   {
>   	struct dce_i2c_sw *dce_i2c_sw =
> @@ -714,7 +714,7 @@ static const struct encoder_feature_support link_enc_feature = {
>   		.flags.bits.IS_TPS3_CAPABLE = true
>   };
>   
> -struct link_encoder *dce80_link_encoder_create(
> +static struct link_encoder *dce80_link_encoder_create(
>   	const struct encoder_init_data *enc_init_data)
>   {
>   	struct dce110_link_encoder *enc110 =
> @@ -753,7 +753,7 @@ static struct panel_cntl *dce80_panel_cntl_create(const struct panel_cntl_init_d
>   	return &panel_cntl->base;
>   }
>   
> -struct clock_source *dce80_clock_source_create(
> +static struct clock_source *dce80_clock_source_create(
>   	struct dc_context *ctx,
>   	struct dc_bios *bios,
>   	enum clock_source_id id,
> @@ -777,7 +777,7 @@ struct clock_source *dce80_clock_source_create(
>   	return NULL;
>   }
>   
> -void dce80_clock_source_destroy(struct clock_source **clk_src)
> +static void dce80_clock_source_destroy(struct clock_source **clk_src)
>   {
>   	kfree(TO_DCE110_CLK_SRC(*clk_src));
>   	*clk_src = NULL;
> @@ -867,7 +867,7 @@ static void dce80_resource_destruct(struct dce110_resource_pool *pool)
>   	}
>   }
>   
> -bool dce80_validate_bandwidth(
> +static bool dce80_validate_bandwidth(
>   	struct dc *dc,
>   	struct dc_state *context,
>   	bool fast_validate)
> @@ -912,7 +912,7 @@ static bool dce80_validate_surface_sets(
>   	return true;
>   }
>   
> -enum dc_status dce80_validate_global(
> +static enum dc_status dce80_validate_global(
>   		struct dc *dc,
>   		struct dc_state *context)
>   {
>