From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: nick.hawkins@hpe.com, verdun@hpe.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, linux@armlinux.org.uk, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/5] dt-bindings: i2c: Add hpe,gxp-i2c Date: Sun, 22 Jan 2023 15:02:50 +0100 [thread overview] Message-ID: <d63231dd-38a7-2cf4-3433-8f28018665f6@linaro.org> (raw) In-Reply-To: <20230120190159.23459-3-nick.hawkins@hpe.com> On 20/01/2023 20:01, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > > Document compatibility string to support I2C controller > in GXP. > > Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> > > --- > > v3: > *Provide better description with use of Phandle > v2: > *Removed uneccessary size-cells and address-cells > *Removed phandle from hpe,sysreg-phandle > *Changed hpe,i2c-max-bus-freq to clock-frequency > --- > .../devicetree/bindings/i2c/hpe,gxp-i2c.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml b/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > new file mode 100644 > index 000000000000..63bc69e92d0e > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/hpe,gxp-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP SoC I2C Controller > + > +maintainers: > + - Nick Hawkins <nick.hawkins@hpe.com> > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: hpe,gxp-i2c > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + clock-frequency: > + default: 100000 > + > + hpe,sysreg: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to a global status and enable registers shared > + between each I2C controller instance. Each bit of the > + registers represents an individual I2C engine. But what is the purpose? What is it doing? Why I2C controller needs it? > + > +required: > + - compatible > + - reg > + - interrupts Keep the same order as in properties: Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: nick.hawkins@hpe.com, verdun@hpe.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, linux@armlinux.org.uk, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/5] dt-bindings: i2c: Add hpe,gxp-i2c Date: Sun, 22 Jan 2023 15:02:50 +0100 [thread overview] Message-ID: <d63231dd-38a7-2cf4-3433-8f28018665f6@linaro.org> (raw) In-Reply-To: <20230120190159.23459-3-nick.hawkins@hpe.com> On 20/01/2023 20:01, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > > Document compatibility string to support I2C controller > in GXP. > > Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> > > --- > > v3: > *Provide better description with use of Phandle > v2: > *Removed uneccessary size-cells and address-cells > *Removed phandle from hpe,sysreg-phandle > *Changed hpe,i2c-max-bus-freq to clock-frequency > --- > .../devicetree/bindings/i2c/hpe,gxp-i2c.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml b/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > new file mode 100644 > index 000000000000..63bc69e92d0e > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/hpe,gxp-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP SoC I2C Controller > + > +maintainers: > + - Nick Hawkins <nick.hawkins@hpe.com> > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: hpe,gxp-i2c > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + clock-frequency: > + default: 100000 > + > + hpe,sysreg: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to a global status and enable registers shared > + between each I2C controller instance. Each bit of the > + registers represents an individual I2C engine. But what is the purpose? What is it doing? Why I2C controller needs it? > + > +required: > + - compatible > + - reg > + - interrupts Keep the same order as in properties: Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-22 14:02 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-20 19:01 [PATCH v3 0/5] ARM: Add GXP I2C Support nick.hawkins 2023-01-20 19:01 ` nick.hawkins 2023-01-20 19:01 ` [PATCH v3 1/5] i2c: hpe: Add GXP SoC I2C Controller nick.hawkins 2023-01-20 19:01 ` nick.hawkins 2023-01-20 23:02 ` kernel test robot 2023-01-20 23:02 ` kernel test robot 2023-01-23 5:11 ` Joel Stanley 2023-01-23 5:11 ` Joel Stanley 2023-01-23 15:41 ` Hawkins, Nick 2023-01-23 15:41 ` Hawkins, Nick 2023-01-20 19:01 ` [PATCH v3 2/5] dt-bindings: i2c: Add hpe,gxp-i2c nick.hawkins 2023-01-20 19:01 ` nick.hawkins 2023-01-22 14:02 ` Krzysztof Kozlowski [this message] 2023-01-22 14:02 ` Krzysztof Kozlowski 2023-01-23 20:05 ` Hawkins, Nick 2023-01-23 20:05 ` Hawkins, Nick 2023-01-20 19:01 ` [PATCH v3 3/5] ARM: dts: hpe: Add I2C Topology nick.hawkins 2023-01-20 19:01 ` nick.hawkins 2023-01-20 19:01 ` [PATCH v3 4/5] ARM: multi_v7_defconfig: add gxp i2c module nick.hawkins 2023-01-20 19:01 ` nick.hawkins 2023-01-20 19:01 ` [PATCH v3 5/5] MAINTAINERS: Add HPE GXP I2C Support nick.hawkins 2023-01-20 19:01 ` nick.hawkins
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d63231dd-38a7-2cf4-3433-8f28018665f6@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=nick.hawkins@hpe.com \ --cc=robh+dt@kernel.org \ --cc=verdun@hpe.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.