From: Sudeep Holla <sudeep.holla@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>, Leo Yan <leo.yan@linaro.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Wei Xu <xuwei5@hisilicon.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH v8 5/7] coresight: add support for CPU debug module
Date: Fri, 5 May 2017 16:04:15 +0100 [thread overview]
Message-ID: <d683a786-b6f2-2d95-2a42-c82b38200bfa@arm.com> (raw)
In-Reply-To: <20170505144832.GA4507@linaro.org>
On 05/05/17 15:48, Mathieu Poirier wrote:
> On Fri, May 05, 2017 at 02:55:17PM +0100, Sudeep Holla wrote:
[...]
>>
>> Just curious as why this is not registered under coresight bus using
>> coresight_register ? It would be good to group all the coresight devices
>> under that bus if possible.
>
> The only thing this driver has in common with the coresight framework is the
> name, everything else is completely different. Coupling them together (because
> of the name) would introduce a lot of hacks and make the code unintelligible.
>
I guessed so from the quick glance at it as it needs descriptors with
notion of source, sink and links to register. However I felt odd to not
group under the same "coresight" bus. As someone with least knowledge
on coresight, I would check under "sys/bus/coresight" to check available
devices on the system.
Anyways that's just my thoughts though I agree with you. It may need
more refactoring to support that and it will look hackish if we try to
do that with the code as it stands.
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 5/7] coresight: add support for CPU debug module
Date: Fri, 5 May 2017 16:04:15 +0100 [thread overview]
Message-ID: <d683a786-b6f2-2d95-2a42-c82b38200bfa@arm.com> (raw)
In-Reply-To: <20170505144832.GA4507@linaro.org>
On 05/05/17 15:48, Mathieu Poirier wrote:
> On Fri, May 05, 2017 at 02:55:17PM +0100, Sudeep Holla wrote:
[...]
>>
>> Just curious as why this is not registered under coresight bus using
>> coresight_register ? It would be good to group all the coresight devices
>> under that bus if possible.
>
> The only thing this driver has in common with the coresight framework is the
> name, everything else is completely different. Coupling them together (because
> of the name) would introduce a lot of hacks and make the code unintelligible.
>
I guessed so from the quick glance at it as it needs descriptors with
notion of source, sink and links to register. However I felt odd to not
group under the same "coresight" bus. As someone with least knowledge
on coresight, I would check under "sys/bus/coresight" to check available
devices on the system.
Anyways that's just my thoughts though I agree with you. It may need
more refactoring to support that and it will look hackish if we try to
do that with the code as it stands.
--
Regards,
Sudeep
next prev parent reply other threads:[~2017-05-05 15:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 10:08 [PATCH v8 0/7] coresight: enable debug module Leo Yan
2017-05-02 10:08 ` Leo Yan
2017-05-02 10:08 ` [PATCH v8 1/7] coresight: bindings for CPU " Leo Yan
2017-05-02 10:08 ` Leo Yan
2017-05-02 10:08 ` [PATCH v8 2/7] doc: Add documentation for Coresight CPU debug Leo Yan
2017-05-02 10:08 ` Leo Yan
[not found] ` <1493719717-27698-3-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-05-03 22:29 ` Mathieu Poirier
2017-05-03 22:29 ` Mathieu Poirier
2017-05-03 22:29 ` Mathieu Poirier
2017-05-09 2:55 ` Leo Yan
2017-05-09 2:55 ` Leo Yan
[not found] ` <1493719717-27698-1-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-05-02 10:08 ` [PATCH v8 3/7] coresight: of_get_coresight_platform_data: Add missing of_node_put Leo Yan
2017-05-02 10:08 ` Leo Yan
2017-05-02 10:08 ` Leo Yan
2017-05-02 10:08 ` [PATCH v8 5/7] coresight: add support for CPU debug module Leo Yan
2017-05-02 10:08 ` Leo Yan
2017-05-02 10:08 ` Leo Yan
2017-05-03 22:24 ` Mathieu Poirier
2017-05-03 22:24 ` Mathieu Poirier
2017-05-05 13:55 ` Sudeep Holla
2017-05-05 13:55 ` Sudeep Holla
2017-05-05 14:48 ` Mathieu Poirier
2017-05-05 14:48 ` Mathieu Poirier
2017-05-05 15:04 ` Sudeep Holla [this message]
2017-05-05 15:04 ` Sudeep Holla
2017-05-05 15:34 ` Mathieu Poirier
2017-05-05 15:34 ` Mathieu Poirier
2017-05-05 15:34 ` Mathieu Poirier
2017-05-02 10:08 ` [PATCH v8 4/7] coresight: refactor with function of_coresight_get_cpu Leo Yan
2017-05-02 10:08 ` Leo Yan
2017-05-02 10:08 ` [PATCH v8 6/7] arm64: dts: hi6220: register debug module Leo Yan
2017-05-02 10:08 ` Leo Yan
2017-05-02 10:08 ` [PATCH v8 7/7] arm64: dts: qcom: msm8916: Add debug unit Leo Yan
2017-05-02 10:08 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d683a786-b6f2-2d95-2a42-c82b38200bfa@arm.com \
--to=sudeep.holla@arm.com \
--cc=andy.gross@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.