From: Lionel Landwerlin <lionel.g.landwerlin@intel.com> To: Rodrigo Vivi <rodrigo.vivi@intel.com>, stable@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org, dmitry.v.rogozhkin@intel.com, Chris Wilson <chris@chris-wilson.co.uk>, Tvrtko Ursulin <tvrtko.ursulin@intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Subject: Re: [PATCH] drm/i915: fix broadwell EU computation Date: Thu, 29 Aug 2019 00:22:27 +0300 [thread overview] Message-ID: <d7faaa1c-362f-ce9e-bbc9-adb5a7400b1f@intel.com> (raw) In-Reply-To: <20190828210209.10541-1-rodrigo.vivi@intel.com> On 29/08/2019 00:02, Rodrigo Vivi wrote: > From: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > > commit 6a67a20366f894c172734f28c5646bdbe48a46e3 upstream. > > subslice_mask is an array indexed by slice, not subslice. > > Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > Fixes: 8cc7669355136f ("drm/i915: store all subslice masks") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712 > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Link: https://patchwork.freedesktop.org/patch/msgid/20181112123931.2815-1-lionel.g.landwerlin@intel.com > (cherry picked from commit 63ac3328f0d1d37f286e397b14d9596ed09d7ca5) > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: <stable@vger.kernel.org> # 4.17 Rodrigo pointed out I forgot the Cc: tag which is why this didn't make it to stable. The same bug showed up on a CentOS kernel : https://github.com/intel/compute-runtime/issues/200 My bad... :( Thanks for resending! -Lionel > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/intel_device_info.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c > index 0ef0c6448d53..01fa98299bae 100644 > --- a/drivers/gpu/drm/i915/intel_device_info.c > +++ b/drivers/gpu/drm/i915/intel_device_info.c > @@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv) > u8 eu_disabled_mask; > u32 n_disabled; > > - if (!(sseu->subslice_mask[ss] & BIT(ss))) > + if (!(sseu->subslice_mask[s] & BIT(ss))) > /* skip disabled subslice */ > continue; >
WARNING: multiple messages have this Message-ID (diff)
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com> To: Rodrigo Vivi <rodrigo.vivi@intel.com>, stable@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/i915: fix broadwell EU computation Date: Thu, 29 Aug 2019 00:22:27 +0300 [thread overview] Message-ID: <d7faaa1c-362f-ce9e-bbc9-adb5a7400b1f@intel.com> (raw) In-Reply-To: <20190828210209.10541-1-rodrigo.vivi@intel.com> On 29/08/2019 00:02, Rodrigo Vivi wrote: > From: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > > commit 6a67a20366f894c172734f28c5646bdbe48a46e3 upstream. > > subslice_mask is an array indexed by slice, not subslice. > > Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > Fixes: 8cc7669355136f ("drm/i915: store all subslice masks") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712 > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Link: https://patchwork.freedesktop.org/patch/msgid/20181112123931.2815-1-lionel.g.landwerlin@intel.com > (cherry picked from commit 63ac3328f0d1d37f286e397b14d9596ed09d7ca5) > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: <stable@vger.kernel.org> # 4.17 Rodrigo pointed out I forgot the Cc: tag which is why this didn't make it to stable. The same bug showed up on a CentOS kernel : https://github.com/intel/compute-runtime/issues/200 My bad... :( Thanks for resending! -Lionel > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/intel_device_info.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c > index 0ef0c6448d53..01fa98299bae 100644 > --- a/drivers/gpu/drm/i915/intel_device_info.c > +++ b/drivers/gpu/drm/i915/intel_device_info.c > @@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv) > u8 eu_disabled_mask; > u32 n_disabled; > > - if (!(sseu->subslice_mask[ss] & BIT(ss))) > + if (!(sseu->subslice_mask[s] & BIT(ss))) > /* skip disabled subslice */ > continue; > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-28 21:22 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-28 21:02 [PATCH] drm/i915: fix broadwell EU computation Rodrigo Vivi 2019-08-28 21:22 ` Lionel Landwerlin [this message] 2019-08-28 21:22 ` Lionel Landwerlin 2019-08-29 21:02 ` Sasha Levin 2019-08-29 21:02 ` Sasha Levin 2019-08-28 21:40 ` ✗ Fi.CI.BAT: failure for drm/i915: fix broadwell EU computation (rev2) Patchwork -- strict thread matches above, loose matches on Subject: below -- 2018-11-12 12:39 [PATCH] drm/i915: fix broadwell EU computation Lionel Landwerlin 2018-11-12 15:44 ` Chris Wilson 2018-11-12 15:57 ` Tvrtko Ursulin 2018-11-12 17:42 ` Lionel Landwerlin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d7faaa1c-362f-ce9e-bbc9-adb5a7400b1f@intel.com \ --to=lionel.g.landwerlin@intel.com \ --cc=chris@chris-wilson.co.uk \ --cc=dmitry.v.rogozhkin@intel.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=joonas.lahtinen@linux.intel.com \ --cc=rodrigo.vivi@intel.com \ --cc=stable@vger.kernel.org \ --cc=tvrtko.ursulin@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.