All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kevin Hilman <khilman@baylibre.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: meson-gxbb-wetek: use updated LED bindings
Date: Mon, 15 Nov 2021 10:25:10 +0100	[thread overview]
Message-ID: <d8bac7a1-0d0f-7c07-ad50-7d317f22fab5@baylibre.com> (raw)
In-Reply-To: <20211012052522.30873-4-christianshewitt@gmail.com>

On 12/10/2021 07:25, Christian Hewitt wrote:
> Update the dts to use the newer style of LED bindings.
> 
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> index a4d34398da35..94dafb955301 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> @@ -7,6 +7,7 @@
>  
>  #include "meson-gxbb.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>  
>  / {
>  	aliases {
> @@ -26,8 +27,10 @@
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		led-system {
> -			label = "wetek-play:system-status";
> +		led-power {
> +			/* red in suspend or power-off */
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_POWER;
>  			gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_HIGH>;
>  			default-state = "on";
>  			panic-indicator;
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kevin Hilman <khilman@baylibre.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: meson-gxbb-wetek: use updated LED bindings
Date: Mon, 15 Nov 2021 10:25:10 +0100	[thread overview]
Message-ID: <d8bac7a1-0d0f-7c07-ad50-7d317f22fab5@baylibre.com> (raw)
In-Reply-To: <20211012052522.30873-4-christianshewitt@gmail.com>

On 12/10/2021 07:25, Christian Hewitt wrote:
> Update the dts to use the newer style of LED bindings.
> 
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> index a4d34398da35..94dafb955301 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> @@ -7,6 +7,7 @@
>  
>  #include "meson-gxbb.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>  
>  / {
>  	aliases {
> @@ -26,8 +27,10 @@
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		led-system {
> -			label = "wetek-play:system-status";
> +		led-power {
> +			/* red in suspend or power-off */
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_POWER;
>  			gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_HIGH>;
>  			default-state = "on";
>  			panic-indicator;
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kevin Hilman <khilman@baylibre.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: meson-gxbb-wetek: use updated LED bindings
Date: Mon, 15 Nov 2021 10:25:10 +0100	[thread overview]
Message-ID: <d8bac7a1-0d0f-7c07-ad50-7d317f22fab5@baylibre.com> (raw)
In-Reply-To: <20211012052522.30873-4-christianshewitt@gmail.com>

On 12/10/2021 07:25, Christian Hewitt wrote:
> Update the dts to use the newer style of LED bindings.
> 
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> index a4d34398da35..94dafb955301 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> @@ -7,6 +7,7 @@
>  
>  #include "meson-gxbb.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>  
>  / {
>  	aliases {
> @@ -26,8 +27,10 @@
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		led-system {
> -			label = "wetek-play:system-status";
> +		led-power {
> +			/* red in suspend or power-off */
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_POWER;
>  			gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_HIGH>;
>  			default-state = "on";
>  			panic-indicator;
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2021-11-15  9:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12  5:25 [PATCH 0/3] arm64: dts: meson: fixups for WeTek common dtsi Christian Hewitt
2021-10-12  5:25 ` Christian Hewitt
2021-10-12  5:25 ` Christian Hewitt
2021-10-12  5:25 ` [PATCH 1/3] arm64: dts: meson-gxbb-wetek: fix HDMI in early boot Christian Hewitt
2021-10-12  5:25   ` Christian Hewitt
2021-10-12  5:25   ` Christian Hewitt
2021-11-15  9:24   ` Neil Armstrong
2021-11-15  9:24     ` Neil Armstrong
2021-11-15  9:24     ` Neil Armstrong
2021-10-12  5:25 ` [PATCH 2/3] arm64: dts: meson-gxbb-wetek: fix missing GPIO binding Christian Hewitt
2021-10-12  5:25   ` Christian Hewitt
2021-10-12  5:25   ` Christian Hewitt
2021-11-15  9:24   ` Neil Armstrong
2021-11-15  9:24     ` Neil Armstrong
2021-11-15  9:24     ` Neil Armstrong
2021-10-12  5:25 ` [PATCH 3/3] arm64: dts: meson-gxbb-wetek: use updated LED bindings Christian Hewitt
2021-10-12  5:25   ` Christian Hewitt
2021-10-12  5:25   ` Christian Hewitt
2021-11-15  9:25   ` Neil Armstrong [this message]
2021-11-15  9:25     ` Neil Armstrong
2021-11-15  9:25     ` Neil Armstrong
2021-11-15  9:29 ` [PATCH 0/3] arm64: dts: meson: fixups for WeTek common dtsi Neil Armstrong
2021-11-15  9:29   ` Neil Armstrong
2021-11-15  9:29   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8bac7a1-0d0f-7c07-ad50-7d317f22fab5@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=christianshewitt@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.