From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
<bjorn.andersson@linaro.org>, <ohad@wizery.com>,
<mcoquelin.stm32@gmail.com>, <alexandre.torgue@st.com>
Cc: <loic.pallardy@st.com>, <linux-remoteproc@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 08/12] remoteproc: stm32: Introduce new start ops for synchronisation
Date: Wed, 29 Apr 2020 16:50:02 +0200 [thread overview]
Message-ID: <d9df6dba-6e99-d3cb-56e5-d7b9be0925f8@st.com> (raw)
In-Reply-To: <20200424202505.29562-9-mathieu.poirier@linaro.org>
On 4/24/20 10:25 PM, Mathieu Poirier wrote:
> Introduce new start functions to be used when synchonising with an MCU.
>
> Mainly based on the work published by Arnaud Pouliquen [1].
>
> [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=239877
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Thanks,
Arnaud
> ---
> drivers/remoteproc/stm32_rproc.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 8ba69e903851..404f17a97095 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -449,6 +449,13 @@ static int stm32_rproc_start(struct rproc *rproc)
> return stm32_rproc_set_hold_boot(rproc, true);
> }
>
> +static int stm32_rproc_sync_start(struct rproc *rproc)
> +{
> + stm32_rproc_add_coredump_trace(rproc);
> +
> + return stm32_rproc_set_hold_boot(rproc, true);
> +}
> +
> static int stm32_rproc_stop(struct rproc *rproc)
> {
> struct stm32_rproc *ddata = rproc->priv;
> @@ -522,6 +529,10 @@ static struct rproc_ops st_rproc_ops = {
> .get_boot_addr = rproc_elf_get_boot_addr,
> };
>
> +static __maybe_unused struct rproc_ops st_rproc_sync_ops = {
> + .start = stm32_rproc_sync_start,
> +};
> +
> static const struct of_device_id stm32_rproc_match[] = {
> { .compatible = "st,stm32mp1-m4" },
> {},
>
WARNING: multiple messages have this Message-ID (diff)
From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
<bjorn.andersson@linaro.org>, <ohad@wizery.com>,
<mcoquelin.stm32@gmail.com>, <alexandre.torgue@st.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-remoteproc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com, loic.pallardy@st.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 08/12] remoteproc: stm32: Introduce new start ops for synchronisation
Date: Wed, 29 Apr 2020 16:50:02 +0200 [thread overview]
Message-ID: <d9df6dba-6e99-d3cb-56e5-d7b9be0925f8@st.com> (raw)
In-Reply-To: <20200424202505.29562-9-mathieu.poirier@linaro.org>
On 4/24/20 10:25 PM, Mathieu Poirier wrote:
> Introduce new start functions to be used when synchonising with an MCU.
>
> Mainly based on the work published by Arnaud Pouliquen [1].
>
> [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=239877
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Thanks,
Arnaud
> ---
> drivers/remoteproc/stm32_rproc.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 8ba69e903851..404f17a97095 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -449,6 +449,13 @@ static int stm32_rproc_start(struct rproc *rproc)
> return stm32_rproc_set_hold_boot(rproc, true);
> }
>
> +static int stm32_rproc_sync_start(struct rproc *rproc)
> +{
> + stm32_rproc_add_coredump_trace(rproc);
> +
> + return stm32_rproc_set_hold_boot(rproc, true);
> +}
> +
> static int stm32_rproc_stop(struct rproc *rproc)
> {
> struct stm32_rproc *ddata = rproc->priv;
> @@ -522,6 +529,10 @@ static struct rproc_ops st_rproc_ops = {
> .get_boot_addr = rproc_elf_get_boot_addr,
> };
>
> +static __maybe_unused struct rproc_ops st_rproc_sync_ops = {
> + .start = stm32_rproc_sync_start,
> +};
> +
> static const struct of_device_id stm32_rproc_match[] = {
> { .compatible = "st,stm32mp1-m4" },
> {},
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-29 14:50 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 20:24 [PATCH v2 00/12] remoteproc: stm32: Add support for synchronising with M4 Mathieu Poirier
2020-04-24 20:24 ` Mathieu Poirier
2020-04-24 20:24 ` [PATCH v2 01/12] remoteproc: stm32: Decouple rproc from memory translation Mathieu Poirier
2020-04-24 20:24 ` Mathieu Poirier
2020-05-14 4:57 ` Bjorn Andersson
2020-05-14 4:57 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 02/12] remoteproc: stm32: Request IRQ with platform device Mathieu Poirier
2020-04-24 20:24 ` Mathieu Poirier
2020-05-14 4:57 ` Bjorn Andersson
2020-05-14 4:57 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 03/12] remoteproc: stm32: Decouple rproc from DT parsing Mathieu Poirier
2020-04-24 20:24 ` Mathieu Poirier
2020-04-29 13:37 ` Arnaud POULIQUEN
2020-04-29 13:37 ` Arnaud POULIQUEN
2020-04-30 20:58 ` Mathieu Poirier
2020-04-30 20:58 ` Mathieu Poirier
2020-05-14 4:59 ` Bjorn Andersson
2020-05-14 4:59 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 04/12] remoteproc: stm32: Remove memory translation " Mathieu Poirier
2020-04-24 20:24 ` Mathieu Poirier
2020-05-14 5:03 ` Bjorn Andersson
2020-05-14 5:03 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 05/12] remoteproc: stm32: Parse syscon that will manage M4 synchronisation Mathieu Poirier
2020-04-24 20:24 ` Mathieu Poirier
2020-05-14 5:03 ` Bjorn Andersson
2020-05-14 5:03 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 06/12] remoteproc: stm32: Get coprocessor state Mathieu Poirier
2020-04-24 20:24 ` Mathieu Poirier
2020-04-29 13:38 ` Arnaud POULIQUEN
2020-04-29 13:38 ` Arnaud POULIQUEN
2020-05-01 17:40 ` Mathieu Poirier
2020-05-01 17:40 ` Mathieu Poirier
2020-04-24 20:25 ` [PATCH v2 07/12] remoteproc: stm32: Get loaded resource table for synchronisation Mathieu Poirier
2020-04-24 20:25 ` Mathieu Poirier
2020-04-24 20:25 ` [PATCH v2 08/12] remoteproc: stm32: Introduce new start ops " Mathieu Poirier
2020-04-24 20:25 ` Mathieu Poirier
2020-04-29 14:50 ` Arnaud POULIQUEN [this message]
2020-04-29 14:50 ` Arnaud POULIQUEN
2020-04-24 20:25 ` [PATCH v2 09/12] remoteproc: stm32: Update M4 state in stm32_rproc_stop() Mathieu Poirier
2020-04-24 20:25 ` Mathieu Poirier
2020-04-29 14:52 ` Arnaud POULIQUEN
2020-04-29 14:52 ` Arnaud POULIQUEN
2020-04-24 20:25 ` [PATCH v2 10/12] remoteproc: stm32: Introduce new parse fw ops for synchronisation Mathieu Poirier
2020-04-24 20:25 ` Mathieu Poirier
2020-05-14 5:13 ` Bjorn Andersson
2020-05-14 5:13 ` Bjorn Andersson
2020-04-24 20:25 ` [PATCH v2 11/12] remoteproc: stm32: Introduce new loaded rsc " Mathieu Poirier
2020-04-24 20:25 ` Mathieu Poirier
2020-05-14 5:15 ` Bjorn Andersson
2020-05-14 5:15 ` Bjorn Andersson
2020-04-24 20:25 ` [PATCH v2 12/12] remoteproc: stm32: Set synchronisation state machine if needed Mathieu Poirier
2020-04-24 20:25 ` Mathieu Poirier
2020-04-29 14:47 ` Arnaud POULIQUEN
2020-04-29 14:47 ` Arnaud POULIQUEN
2020-05-01 17:54 ` Mathieu Poirier
2020-05-01 17:54 ` Mathieu Poirier
2020-04-29 15:08 ` [PATCH v2 00/12] remoteproc: stm32: Add support for synchronising with M4 Arnaud POULIQUEN
2020-04-29 15:08 ` Arnaud POULIQUEN
2020-05-01 17:59 ` Mathieu Poirier
2020-05-01 17:59 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9df6dba-6e99-d3cb-56e5-d7b9be0925f8@st.com \
--to=arnaud.pouliquen@st.com \
--cc=alexandre.torgue@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=loic.pallardy@st.com \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.