* [PATCH v2] mm/damon/paddr: fix missing folio_put()
@ 2023-02-22 6:27 Andrew Yang
0 siblings, 0 replies; only message in thread
From: Andrew Yang @ 2023-02-22 6:27 UTC (permalink / raw)
To: SeongJae Park, Andrew Morton, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: wsd_upstream, casper.li, andrew.yang, damon, linux-mm,
linux-kernel, linux-arm-kernel, linux-mediatek
From: "andrew.yang" <andrew.yang@mediatek.com>
damon_get_folio() would always increase folio _refcount and
folio_isolate_lru() would increase folio _refcount if the folio's lru
flag is set.
If an unevictable folio isolated successfully, there will be two more
_refcount. The one from folio_isolate_lru() will be decreased in
folio_puback_lru(), but the other one from damon_get_folio() will be
left behind. This causes a pin page.
Whatever the case, the _refcount from damon_get_folio() should be
decreased.
Signed-off-by: andrew.yang <andrew.yang@mediatek.com>
---
v2:
according to David's suggestion
1. revise subject
according to SeongJae's suggestions
1. rebase to mm-unstable tree
2. remove braces for th single statements
---
mm/damon/paddr.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
index 607bb69e526c..6c655d9b5639 100644
--- a/mm/damon/paddr.c
+++ b/mm/damon/paddr.c
@@ -250,12 +250,11 @@ static unsigned long damon_pa_pageout(struct damon_region *r, struct damos *s)
folio_put(folio);
continue;
}
- if (folio_test_unevictable(folio)) {
+ if (folio_test_unevictable(folio))
folio_putback_lru(folio);
- } else {
+ else
list_add(&folio->lru, &folio_list);
- folio_put(folio);
- }
+ folio_put(folio);
}
applied = reclaim_pages(&folio_list);
cond_resched();
--
2.18.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-22 6:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-22 6:27 [PATCH v2] mm/damon/paddr: fix missing folio_put() Andrew Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).