damon.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] mm/damon/core: fix divide error in damon_nr_accesses_to_accesses_bp()
@ 2023-05-27  3:21 Kefeng Wang
  0 siblings, 0 replies; only message in thread
From: Kefeng Wang @ 2023-05-27  3:21 UTC (permalink / raw)
  To: SeongJae Park, Andrew Morton, damon, linux-mm
  Cc: linux-kernel, Kefeng Wang, syzbot+841a46899768ec7bec67, stable

If 'aggr_interval' is smaller than 'sample_interval', max_nr_accesses
in damon_nr_accesses_to_accesses_bp() becomes zero which leads to divide
error, let's validate the values of them in damon_set_attrs() to fix it,
which similar to others attrs check.

Reported-by: syzbot+841a46899768ec7bec67@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=841a46899768ec7bec67
Link: https://lore.kernel.org/damon/00000000000055fc4e05fc975bc2@google.com/
Fixes: 2f5bef5a590b ("mm/damon/core: update monitoring results for new monitoring attributes")
Cc: <stable@vger.kernel.org> # 6.3.x-
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
v2: close checkpatch warning, add RB/cc stable, per SJ

 mm/damon/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index d9ef62047bf5..91cff7f2997e 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -551,6 +551,8 @@ int damon_set_attrs(struct damon_ctx *ctx, struct damon_attrs *attrs)
 		return -EINVAL;
 	if (attrs->min_nr_regions > attrs->max_nr_regions)
 		return -EINVAL;
+	if (attrs->sample_interval > attrs->aggr_interval)
+		return -EINVAL;
 	damon_update_monitoring_results(ctx, attrs);
 	ctx->attrs = *attrs;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-27  3:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-27  3:21 [PATCH v2] mm/damon/core: fix divide error in damon_nr_accesses_to_accesses_bp() Kefeng Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).