From: Herbert Xu <herbert@gondor.apana.org.au>
To: Brian Koropoff <bkoropoff@gmail.com>
Cc: dash@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix additional use of 'j' printf length modifier.
Date: Thu, 7 Jul 2011 14:41:54 +0800 [thread overview]
Message-ID: <20110707064154.GE16157@gondor.apana.org.au> (raw)
In-Reply-To: <1302921279.2620.6.camel@gemini>
On Sat, Apr 16, 2011 at 02:34:39AM +0000, Brian Koropoff wrote:
> The printf builtin modifies the user's format strings
> by prefixing integer conversion specifications with the
> 'j' (intmax_t) length modifier. Since this is not portable,
> instead prefix them with the length modifier extracted from
> the PRIdMAX constant.
>
> Signed-off-by: Brian Koropoff <bkoropoff@gmail.com>
I'm sorry but I'm not taking this. %j is part of ISO C99 and
POSIX so please fix your build environment instead.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2011-07-07 6:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-16 2:30 Fix for Solaris patch and new HP-UX patch Brian Koropoff
2011-04-16 2:34 ` [PATCH 1/2] Fix additional use of 'j' printf length modifier Brian Koropoff
2011-04-16 4:54 ` Jonathan Nieder
2011-04-16 18:25 ` Brian Koropoff
2011-07-07 6:41 ` Herbert Xu [this message]
2011-07-07 7:12 ` Jonathan Nieder
2011-07-07 7:32 ` Brian Koropoff
2011-07-07 7:44 ` Herbert Xu
2011-04-16 2:34 ` [PATCH 2/2] Port to HP-UX Brian Koropoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707064154.GE16157@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=bkoropoff@gmail.com \
--cc=dash@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).