dash.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Koropoff <bkoropoff@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, dash@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix additional use of 'j' printf length modifier.
Date: Thu, 07 Jul 2011 00:32:25 -0700	[thread overview]
Message-ID: <4E156109.4080600@gmail.com> (raw)
In-Reply-To: <20110707071244.GB11514@elie>

On 07/07/2011 12:12 AM, Jonathan Nieder wrote:
> Herbert Xu wrote:
>
>> %j is part of ISO C99 and POSIX
> *checks*  Oh, so it is!  Thanks; it's nice to learn the standard
> offers more than expected.
>
> Brian: fwiw gnulib printf seems to provide %j, though of course it's a
> bit more heavyweight.  And of course there are alternative C libraries
> --- e.g., glibc runs on Solaris.

C99 also guarantees the presence of imaxdiv, but arith_yacc.c happily
#ifdefs around it if the build environment lacks it.  I submitted other
patches in the same spirit (working around non-compliant vsnprintf) and they
were accepted.  Would a patch that retains the old code verbatim but
#ifdefs in an alternate implementation on legacy systems be more acceptable?

-- Brian

  reply	other threads:[~2011-07-07  7:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16  2:30 Fix for Solaris patch and new HP-UX patch Brian Koropoff
2011-04-16  2:34 ` [PATCH 1/2] Fix additional use of 'j' printf length modifier Brian Koropoff
2011-04-16  4:54   ` Jonathan Nieder
2011-04-16 18:25     ` Brian Koropoff
2011-07-07  6:41   ` Herbert Xu
2011-07-07  7:12     ` Jonathan Nieder
2011-07-07  7:32       ` Brian Koropoff [this message]
2011-07-07  7:44         ` Herbert Xu
2011-04-16  2:34 ` [PATCH 2/2] Port to HP-UX Brian Koropoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E156109.4080600@gmail.com \
    --to=bkoropoff@gmail.com \
    --cc=dash@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).