From: Jonathan Perkin <jperkin@joyent.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dash@vger.kernel.org
Subject: Re: [SHELL] Fix 64-bit Solaris build
Date: Mon, 6 Jun 2016 16:22:59 +0100 [thread overview]
Message-ID: <20160606152259.GE5022@joyent.com> (raw)
In-Reply-To: <20160606142710.GA23472@gondor.apana.org.au>
* On 2016-06-06 at 15:27 BST, Herbert Xu wrote:
> On Fri, Dec 11, 2015 at 01:07:14PM +0000, Jonathan Perkin wrote:
> > In a 64-bit Solaris environment there is no stat64() function, only
> > stat(). This conflicts with the stat64 #define used to support
> > dietlibc/klibc when stat64() is not found and results in:
> >
> > ./../config.h:194:16: error: redefinition of 'struct stat'
> > #define stat64 stat
> > ^
> > In file included from cd.c:36:0:
> > /usr/include/sys/stat.h:217:8: note: originally defined here
> > struct stat {
> > ^
> >
> > Instead, add a AC_CHECK_DECL test for stat64, and only perform the
> > AC_CHECK_FUNC test if it isn't already defined.
>
> I don't understand, does stat64 exist or not? If it doesn't then
> how can AC_CHECK_DECL help? Or do you mean that it only exists as
> a macro?
Right, it only exists as a macro, defined as
#define stat64 stat
in sys/stat.h. The AC_CHECK_FUNC test fails as it doesn't pull in any
includes, and cannot find a stat64() function in libc.
Adding the AC_CHECK_DECL test finds the definition and avoids running
the AC_CHECK_FUNC tests if that is the case.
--
Jonathan Perkin - Joyent, Inc. - www.joyent.com
next prev parent reply other threads:[~2016-06-06 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 13:07 [PATCH] [SHELL] Fix 64-bit Solaris build Jonathan Perkin
2016-06-06 14:27 ` Herbert Xu
2016-06-06 15:22 ` Jonathan Perkin [this message]
2016-06-07 6:50 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606152259.GE5022@joyent.com \
--to=jperkin@joyent.com \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).