From: Peter Rosin <peda@lysator.liu.se>
To: dash@vger.kernel.org
Subject: [PATCH] [DEBUG] Do not attempt to output a NULL message
Date: Sun, 10 Mar 2013 22:58:38 +0100 [thread overview]
Message-ID: <513D020E.8050704@lysator.liu.se> (raw)
Prevent future problems, as noone calls exverror with a NULL msg
at this time.
Signed-off-by: Peter Rosin <peda@lysator.liu.se>
---
src/error.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
I stumbled on this when reading the code... Or is msg only ever
NULL when DEBUG is #defined?
Cheers,
Peter
diff --git a/src/error.c b/src/error.c
index 9d31989..5ab69c0 100644
--- a/src/error.c
+++ b/src/error.c
@@ -151,8 +151,8 @@ exverror(int cond, const char *msg, va_list ap)
TRACE(("\") pid=%d\n", getpid()));
} else
TRACE(("exverror(%d, NULL) pid=%d\n", cond, getpid()));
- if (msg)
#endif
+ if (msg)
exvwarning(-1, msg, ap);
flushall();
--
1.7.9
reply other threads:[~2013-03-10 22:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513D020E.8050704@lysator.liu.se \
--to=peda@lysator.liu.se \
--cc=dash@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).