dash.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [DEBUG] Do not attempt to output a NULL message
@ 2013-03-10 21:58 Peter Rosin
  0 siblings, 0 replies; only message in thread
From: Peter Rosin @ 2013-03-10 21:58 UTC (permalink / raw)
  To: dash

Prevent future problems, as noone calls exverror with a NULL msg
at this time.

Signed-off-by: Peter Rosin <peda@lysator.liu.se>
---
 src/error.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

I stumbled on this when reading the code... Or is msg only ever
NULL when DEBUG is #defined?

Cheers,
Peter

diff --git a/src/error.c b/src/error.c
index 9d31989..5ab69c0 100644
--- a/src/error.c
+++ b/src/error.c
@@ -151,8 +151,8 @@ exverror(int cond, const char *msg, va_list ap)
 		TRACE(("\") pid=%d\n", getpid()));
 	} else
 		TRACE(("exverror(%d, NULL) pid=%d\n", cond, getpid()));
-	if (msg)
 #endif
+	if (msg)
 		exvwarning(-1, msg, ap);
 
 	flushall();
-- 
1.7.9


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-03-10 22:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-10 21:58 [PATCH] [DEBUG] Do not attempt to output a NULL message Peter Rosin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).