From: Vincent Whitchurch <Vincent.Whitchurch@axis.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>
Cc: Vincent Whitchurch <Vincent.Whitchurch@axis.com>,
"lkp@intel.com" <lkp@intel.com>,
"error27@gmail.com" <error27@gmail.com>
Subject: Re: [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for shared timer
Date: Mon, 3 Apr 2023 12:59:17 +0000 [thread overview]
Message-ID: <db70b75c3eb4160ae25e6f0d6a8219f032cfb416.camel@axis.com> (raw)
In-Reply-To: <20230403094017.9556-1-krzysztof.kozlowski@linaro.org>
On Mon, 2023-04-03 at 11:40 +0200, Krzysztof Kozlowski wrote:
> For a shared timers, the mct_init_dt() should not initialize the clock
> even with global comparator. This is not an error, thus the function
> should simply return 0, not 'ret'.
>
> This also fixes smatch warning:
>
> drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error code? 'ret'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@intel.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
WARNING: multiple messages have this Message-ID (diff)
From: Vincent Whitchurch <Vincent.Whitchurch@axis.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>
Cc: Vincent Whitchurch <Vincent.Whitchurch@axis.com>,
"lkp@intel.com" <lkp@intel.com>,
"error27@gmail.com" <error27@gmail.com>
Subject: Re: [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for shared timer
Date: Mon, 3 Apr 2023 12:59:17 +0000 [thread overview]
Message-ID: <db70b75c3eb4160ae25e6f0d6a8219f032cfb416.camel@axis.com> (raw)
In-Reply-To: <20230403094017.9556-1-krzysztof.kozlowski@linaro.org>
On Mon, 2023-04-03 at 11:40 +0200, Krzysztof Kozlowski wrote:
> For a shared timers, the mct_init_dt() should not initialize the clock
> even with global comparator. This is not an error, thus the function
> should simply return 0, not 'ret'.
>
> This also fixes smatch warning:
>
> drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error code? 'ret'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@intel.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-03 12:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230403094023epcas5p3cb0690c9984ce4d80ede8483a312be4d@epcas5p3.samsung.com>
2023-04-03 9:40 ` [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for shared timer Krzysztof Kozlowski
2023-04-03 9:40 ` Krzysztof Kozlowski
2023-04-03 12:59 ` Vincent Whitchurch [this message]
2023-04-03 12:59 ` Vincent Whitchurch
2023-04-03 16:49 ` Alim Akhtar
2023-04-03 16:49 ` Alim Akhtar
2023-04-06 13:37 ` Daniel Lezcano
2023-04-06 13:37 ` Daniel Lezcano
2023-04-26 9:12 ` [tip: timers/core] clocksource/drivers/exynos_mct: Explicitly " tip-bot2 for Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db70b75c3eb4160ae25e6f0d6a8219f032cfb416.camel@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=alim.akhtar@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=error27@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.