From: Chanwoo Choi <cw00.choi@samsung.com> To: Leonard Crestez <leonard.crestez@nxp.com>, MyungJoo Ham <myungjoo.ham@samsung.com> Cc: "Kyungmin Park" <kyungmin.park@samsung.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, "Matthias Kaehlcke" <mka@chromium.org>, "Artur Świgoń" <a.swigon@partner.samsung.com>, "Georgi Djakov" <georgi.djakov@linaro.org>, "Viresh Kumar" <viresh.kumar@linaro.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, dl-linux-imx <linux-imx@nxp.com> Subject: Re: [PATCH 2/5] PM / devfreq: Split device_register usage Date: Mon, 2 Dec 2019 14:02:57 +0900 [thread overview] Message-ID: <dc635125-8b49-cd7e-304a-681ff47b2011@samsung.com> (raw) In-Reply-To: <VI1PR04MB7023135B9D53D86A101F1895EE430@VI1PR04MB7023.eurprd04.prod.outlook.com> On 12/2/19 1:45 PM, Leonard Crestez wrote: > On 2019-12-02 3:02 AM, Chanwoo Choi wrote: >> On 11/14/19 8:21 AM, Leonard Crestez wrote: >>> Splitting device_register into device_initialize and device_add allows >>> devm-based allocations to be performed before device_add. >>> >>> It also simplifies error paths in devfreq_add_device: just call >>> put_device instead of duplicating parts of devfreq_dev_release. >>> >>> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> >>> --- >>> drivers/devfreq/devfreq.c | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c >>> index 27af1b95fd23..b89a82382536 100644 >>> --- a/drivers/devfreq/devfreq.c >>> +++ b/drivers/devfreq/devfreq.c >>> @@ -689,10 +689,11 @@ struct devfreq *devfreq_add_device(struct device *dev, >>> mutex_init(&devfreq->lock); >>> mutex_lock(&devfreq->lock); >>> devfreq->dev.parent = dev; >>> devfreq->dev.class = devfreq_class; >>> devfreq->dev.release = devfreq_dev_release; >>> + device_initialize(&devfreq->dev); >>> INIT_LIST_HEAD(&devfreq->node); >>> devfreq->profile = profile; >>> strncpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN); >>> devfreq->previous_freq = profile->initial_freq; >>> devfreq->last_status.current_frequency = profile->initial_freq; >>> @@ -726,15 +727,14 @@ struct devfreq *devfreq_add_device(struct device *dev, >>> devfreq->suspend_freq = dev_pm_opp_get_suspend_opp_freq(dev); >>> atomic_set(&devfreq->suspend_count, 0); >>> >>> dev_set_name(&devfreq->dev, "devfreq%d", >>> atomic_inc_return(&devfreq_no)); >>> - err = device_register(&devfreq->dev); >>> + err = device_add(&devfreq->dev); >>> if (err) { >>> mutex_unlock(&devfreq->lock); >>> - put_device(&devfreq->dev); >>> - goto err_out; >>> + goto err_dev; >>> } >>> >>> devfreq->trans_table = devm_kzalloc(&devfreq->dev, >>> array3_size(sizeof(unsigned int), >>> devfreq->profile->max_state, >>> @@ -789,13 +789,13 @@ struct devfreq *devfreq_add_device(struct device *dev, >>> >>> err_init: >>> mutex_unlock(&devfreq_list_lock); >>> err_devfreq: >>> devfreq_remove_device(devfreq); >>> - devfreq = NULL; >>> + return ERR_PTR(err); >>> err_dev: >>> - kfree(devfreq); >>> + put_device(&devfreq->dev); >>> err_out: >>> return ERR_PTR(err); >>> } >>> EXPORT_SYMBOL(devfreq_add_device); >>> >>> >> >> As I previously commented, I don't prefer to split out of bodyf of device_register(). >> Instead, your first version is better without devm. > > Very well, feel free to drop 2-5 of this series then. > > Or perhaps I misunderstood and the locking cleanups would be acceptable > in the variant that removes devm from a few allocations? There's quite a > bunch of stuff flying around the merge window already so I'll refrain > from posting until v5.5-rc1 anyway. Don't need to wait the v5.5-rc1. You can send the patches. But, This series have to be merged to v5.6-rc1. > > I went a little overboard with tricky cleanups and this ended up > delaying the functionality I wanted to push. > > -- > Regards, > Leonard > > -- Best Regards, Chanwoo Choi Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com> To: Leonard Crestez <leonard.crestez@nxp.com>, MyungJoo Ham <myungjoo.ham@samsung.com> Cc: "Artur Świgoń" <a.swigon@partner.samsung.com>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "Viresh Kumar" <viresh.kumar@linaro.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, "Kyungmin Park" <kyungmin.park@samsung.com>, "Matthias Kaehlcke" <mka@chromium.org>, dl-linux-imx <linux-imx@nxp.com>, "Georgi Djakov" <georgi.djakov@linaro.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 2/5] PM / devfreq: Split device_register usage Date: Mon, 2 Dec 2019 14:02:57 +0900 [thread overview] Message-ID: <dc635125-8b49-cd7e-304a-681ff47b2011@samsung.com> (raw) In-Reply-To: <VI1PR04MB7023135B9D53D86A101F1895EE430@VI1PR04MB7023.eurprd04.prod.outlook.com> On 12/2/19 1:45 PM, Leonard Crestez wrote: > On 2019-12-02 3:02 AM, Chanwoo Choi wrote: >> On 11/14/19 8:21 AM, Leonard Crestez wrote: >>> Splitting device_register into device_initialize and device_add allows >>> devm-based allocations to be performed before device_add. >>> >>> It also simplifies error paths in devfreq_add_device: just call >>> put_device instead of duplicating parts of devfreq_dev_release. >>> >>> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> >>> --- >>> drivers/devfreq/devfreq.c | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c >>> index 27af1b95fd23..b89a82382536 100644 >>> --- a/drivers/devfreq/devfreq.c >>> +++ b/drivers/devfreq/devfreq.c >>> @@ -689,10 +689,11 @@ struct devfreq *devfreq_add_device(struct device *dev, >>> mutex_init(&devfreq->lock); >>> mutex_lock(&devfreq->lock); >>> devfreq->dev.parent = dev; >>> devfreq->dev.class = devfreq_class; >>> devfreq->dev.release = devfreq_dev_release; >>> + device_initialize(&devfreq->dev); >>> INIT_LIST_HEAD(&devfreq->node); >>> devfreq->profile = profile; >>> strncpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN); >>> devfreq->previous_freq = profile->initial_freq; >>> devfreq->last_status.current_frequency = profile->initial_freq; >>> @@ -726,15 +727,14 @@ struct devfreq *devfreq_add_device(struct device *dev, >>> devfreq->suspend_freq = dev_pm_opp_get_suspend_opp_freq(dev); >>> atomic_set(&devfreq->suspend_count, 0); >>> >>> dev_set_name(&devfreq->dev, "devfreq%d", >>> atomic_inc_return(&devfreq_no)); >>> - err = device_register(&devfreq->dev); >>> + err = device_add(&devfreq->dev); >>> if (err) { >>> mutex_unlock(&devfreq->lock); >>> - put_device(&devfreq->dev); >>> - goto err_out; >>> + goto err_dev; >>> } >>> >>> devfreq->trans_table = devm_kzalloc(&devfreq->dev, >>> array3_size(sizeof(unsigned int), >>> devfreq->profile->max_state, >>> @@ -789,13 +789,13 @@ struct devfreq *devfreq_add_device(struct device *dev, >>> >>> err_init: >>> mutex_unlock(&devfreq_list_lock); >>> err_devfreq: >>> devfreq_remove_device(devfreq); >>> - devfreq = NULL; >>> + return ERR_PTR(err); >>> err_dev: >>> - kfree(devfreq); >>> + put_device(&devfreq->dev); >>> err_out: >>> return ERR_PTR(err); >>> } >>> EXPORT_SYMBOL(devfreq_add_device); >>> >>> >> >> As I previously commented, I don't prefer to split out of bodyf of device_register(). >> Instead, your first version is better without devm. > > Very well, feel free to drop 2-5 of this series then. > > Or perhaps I misunderstood and the locking cleanups would be acceptable > in the variant that removes devm from a few allocations? There's quite a > bunch of stuff flying around the merge window already so I'll refrain > from posting until v5.5-rc1 anyway. Don't need to wait the v5.5-rc1. You can send the patches. But, This series have to be merged to v5.6-rc1. > > I went a little overboard with tricky cleanups and this ended up > delaying the functionality I wanted to push. > > -- > Regards, > Leonard > > -- Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-02 4:56 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-13 23:21 [PATCH 0/5] PM / devfreq: Don't take lock in devfreq_add_device Leonard Crestez 2019-11-13 23:21 ` Leonard Crestez 2019-11-13 23:21 ` [PATCH 1/5] PM / devfreq: Don't fail devfreq_dev_release if not in list Leonard Crestez 2019-11-13 23:21 ` Leonard Crestez 2019-12-02 1:07 ` Chanwoo Choi 2019-12-02 1:07 ` Chanwoo Choi 2019-11-13 23:21 ` [PATCH 2/5] PM / devfreq: Split device_register usage Leonard Crestez 2019-11-13 23:21 ` Leonard Crestez 2019-12-02 1:08 ` Chanwoo Choi 2019-12-02 1:08 ` Chanwoo Choi 2019-12-02 4:45 ` Leonard Crestez 2019-12-02 4:45 ` Leonard Crestez 2019-12-02 5:02 ` Chanwoo Choi [this message] 2019-12-02 5:02 ` Chanwoo Choi 2019-11-13 23:21 ` [PATCH 3/5] PM / devfreq: Move more initialization before registration Leonard Crestez 2019-11-13 23:21 ` Leonard Crestez 2019-11-13 23:21 ` [PATCH 4/5] PM / devfreq: Don't use devm on parent device Leonard Crestez 2019-11-13 23:21 ` Leonard Crestez 2019-11-13 23:21 ` [PATCH 5/5] PM / devfreq: Don't take lock in devfreq_add_device Leonard Crestez 2019-11-13 23:21 ` Leonard Crestez
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dc635125-8b49-cd7e-304a-681ff47b2011@samsung.com \ --to=cw00.choi@samsung.com \ --cc=a.swigon@partner.samsung.com \ --cc=georgi.djakov@linaro.org \ --cc=kyungmin.park@samsung.com \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-pm@vger.kernel.org \ --cc=mka@chromium.org \ --cc=myungjoo.ham@samsung.com \ --cc=rjw@rjwysocki.net \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.